kubernetes-sigs/kustomize
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/kustomize.git synced 2026-06-12 01:14:22 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Function framework testutil support for functions which refer to local files

Browse Source 
Some functions may read local files using relative paths.  Update the test
framework to `cd` into the directory containing the config.yaml before
running the function.
This commit is contained in:
Phillip Wittrock
2020-11-16 16:35:07 -08:00
parent 2ae180ca23
commit 02e7589323
1 changed files with 20 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
kyaml/fn/framework/frameworktestutil/frameworktestutil.go
View File

@@ -83,16 +83,26 @@ func (rc ResultsChecker) Assert(t *testing.T) bool {
} }
func (rc ResultsChecker) compare(t *testing.T, path string) { func (rc ResultsChecker) compare(t *testing.T, path string) {
// cd into the directory so we can test functions that refer
// local files by relative paths
d, err := os.Getwd()
if !assert.NoError(t, err) {
t.FailNow()
}
defer func() { _ = os.Chdir(d) }()
if !assert.NoError(t, os.Chdir(path)) {
t.FailNow()
}
// make sure this directory contains test data // make sure this directory contains test data
configPath := filepath.Join(path, rc.ConfigInputFilename) _, err = os.Stat(rc.ConfigInputFilename)
_, err := os.Stat(configPath)
if os.IsNotExist(err) { if os.IsNotExist(err) {
// missing input // missing input
return return
} }
args := []string{configPath} args := []string{rc.ConfigInputFilename}
expectedOutput, expectedError := rc.getExpected(t, path) expectedOutput, expectedError := rc.getExpected(t)
if expectedError == "" && expectedOutput == "" { if expectedError == "" && expectedOutput == "" {
// missing expected // missing expected
return return
@@ -104,7 +114,7 @@ func (rc ResultsChecker) compare(t *testing.T, path string) {
// run the test // run the test
t.Run(path, func(t *testing.T) { t.Run(path, func(t *testing.T) {
if rc.InputFilenameGlob != "" { if rc.InputFilenameGlob != "" {
inputs, err := filepath.Glob(filepath.Join(path, rc.InputFilenameGlob)) inputs, err := filepath.Glob(rc.InputFilenameGlob)
if !assert.NoError(t, err) { if !assert.NoError(t, err) {
t.FailNow() t.FailNow()
} }
@@ -140,17 +150,17 @@ func (rc ResultsChecker) compare(t *testing.T, path string) {
} }
// getExpected reads the expected results and error files // getExpected reads the expected results and error files
func (rc ResultsChecker) getExpected(t *testing.T, path string) (string, string) { func (rc ResultsChecker) getExpected(t *testing.T) (string, string) {
// read the expected results // read the expected results
var expectedOutput, expectedError string var expectedOutput, expectedError string
if rc.ExpectedOutputFilename != "" { if rc.ExpectedOutputFilename != "" {
_, err := os.Stat(filepath.Join(path, rc.ExpectedOutputFilename)) _, err := os.Stat(rc.ExpectedOutputFilename)
if !os.IsNotExist(err) && err != nil { if !os.IsNotExist(err) && err != nil {
t.FailNow() t.FailNow()
} }
if err == nil { if err == nil {
// only read the file if it exists // only read the file if it exists
b, err := ioutil.ReadFile(filepath.Join(path, rc.ExpectedOutputFilename)) b, err := ioutil.ReadFile(rc.ExpectedOutputFilename)
if !assert.NoError(t, err) { if !assert.NoError(t, err) {
t.FailNow() t.FailNow()
} }
@@ -158,13 +168,13 @@ func (rc ResultsChecker) getExpected(t *testing.T, path string) (string, string)
} }
} }
if rc.ExpectedErrorFilename != "" { if rc.ExpectedErrorFilename != "" {
_, err := os.Stat(filepath.Join(path, rc.ExpectedErrorFilename)) _, err := os.Stat(rc.ExpectedErrorFilename)
if !os.IsNotExist(err) && err != nil { if !os.IsNotExist(err) && err != nil {
t.FailNow() t.FailNow()
} }
if err == nil { if err == nil {
// only read the file if it exists // only read the file if it exists
b, err := ioutil.ReadFile(filepath.Join(path, rc.ExpectedErrorFilename)) b, err := ioutil.ReadFile(rc.ExpectedErrorFilename)
if !assert.NoError(t, err) { if !assert.NoError(t, err) {
t.FailNow() t.FailNow()
} }