kubernetes-sigs/kustomize
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/kustomize.git synced 2026-06-11 17:12:51 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Activate lint staticcheck.

Browse Source
This commit is contained in:
jregan
2019-11-16 07:02:21 -08:00
parent 2326362fd2
commit 0924269e76
3 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.golangci-kustomize.yml
View File

@@ -21,7 +21,7 @@ linters:
- lll - lll
- misspell - misspell
- nakedret - nakedret
# - staticcheck (panics) - staticcheck
- structcheck - structcheck
# - stylecheck (panics) # - stylecheck (panics)
# - typecheck (fails in lots of places) # - typecheck (fails in lots of places)

1
api/internal/accumulator/refvartransformer.go
View File

@@ -70,6 +70,7 @@ func (rv *refVarTransformer) replaceVars(in interface{}) (interface{}, error) {
// This field can potentially contain a $(VAR) since it is // This field can potentially contain a $(VAR) since it is
// of string type. // of string type.
return expansion2.Expand(s, rv.mappingFunc), nil return expansion2.Expand(s, rv.mappingFunc), nil
//nolint:staticcheck (erroneously claims that `case nil` is unreachable)
case nil: case nil:
return nil, nil return nil, nil
default: default:

2
api/loader/fileloader_test.go
View File

@@ -480,7 +480,7 @@ func TestLoaderDisallowsLocalBaseFromRemoteOverlay(t *testing.T) {
t.Fatalf("unexpected root %s", l2.Root()) t.Fatalf("unexpected root %s", l2.Root())
} }
// This is not okay. // This is not okay.
l3, err = l2.New("../../../highBase") _, err = l2.New("../../../highBase")
if err == nil { if err == nil {
t.Fatalf("expected err") t.Fatalf("expected err")
} }