Activate lint staticcheck.

.golangci-kustomize.yml

@@ -21,7 +21,7 @@ linters:
     - lll
     - misspell
     - nakedret
-    # - staticcheck (panics)
+    - staticcheck
     - structcheck
     # - stylecheck (panics)
     # - typecheck (fails in lots of places)

api/internal/accumulator/refvartransformer.go

@@ -70,6 +70,7 @@ func (rv *refVarTransformer) replaceVars(in interface{}) (interface{}, error) {
 		// This field can potentially contain a $(VAR) since it is
 		// of string type.
 		return expansion2.Expand(s, rv.mappingFunc), nil
+	//nolint:staticcheck (erroneously claims that `case nil` is unreachable)
 	case nil:
 		return nil, nil
 	default:

api/loader/fileloader_test.go

@@ -480,7 +480,7 @@ func TestLoaderDisallowsLocalBaseFromRemoteOverlay(t *testing.T) {
 		t.Fatalf("unexpected root %s", l2.Root())
 	}
 	// This is not okay.
-	l3, err = l2.New("../../../highBase")
+	_, err = l2.New("../../../highBase")
 	if err == nil {
 		t.Fatalf("expected err")
 	}