Fix code to address complains from gocritic (assignOp, ifElseChain and appendAssign)

This commit is contained in:
Arthur Mello
2019-12-06 16:34:27 -03:00
parent 20d995c87e
commit 0a8d7c2be2
2 changed files with 13 additions and 9 deletions

View File

@@ -103,15 +103,16 @@ func (s ValueReplacer) Filter(object *RNode) (*RNode, error) {
if s.Count == 0 {
s.Count = -1
}
if s.StringMatch != "" {
switch {
case s.StringMatch != "":
object.value.Value = strings.Replace(object.value.Value, s.StringMatch, s.Replace, s.Count)
} else if s.RegexMatch != "" {
case s.RegexMatch != "":
r, err := regexp.Compile(s.RegexMatch)
if err != nil {
return nil, fmt.Errorf("ValueReplacer RegexMatch does not compile: %v", err)
}
object.value.Value = r.ReplaceAllString(object.value.Value, s.Replace)
} else {
default:
return nil, fmt.Errorf("ValueReplacer missing StringMatch and RegexMatch")
}
return object, nil
@@ -138,7 +139,7 @@ type SuffixSetter struct {
func (s SuffixSetter) Filter(object *RNode) (*RNode, error) {
if !strings.HasSuffix(object.value.Value, s.Value) {
object.value.Value = object.value.Value + s.Value
object.value.Value += s.Value
}
return object, nil
}