From 0b4df3d414fea202d93f6e015478f72ca739e040 Mon Sep 17 00:00:00 2001 From: Jingfang Liu Date: Thu, 9 Aug 2018 11:25:37 -0700 Subject: [PATCH] Add deprecation message for namePrefix behavior change --- pkg/transformers/prefixname.go | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/pkg/transformers/prefixname.go b/pkg/transformers/prefixname.go index 4070fa095..1da095b04 100644 --- a/pkg/transformers/prefixname.go +++ b/pkg/transformers/prefixname.go @@ -19,6 +19,7 @@ package transformers import ( "errors" "fmt" + "log" "github.com/kubernetes-sigs/kustomize/pkg/resmap" @@ -48,6 +49,11 @@ var skipNamePrefixPathConfigs = []PathConfig{ }, } +// deprecateNamePrefixPathConfig will be moved into skipNamePrefixPathConfigs in next release +var deprecateNamePrefixPathConfig = PathConfig{ + GroupVersionKind: &schema.GroupVersionKind{Kind: "Namespace"}, +} + // NewDefaultingNamePrefixTransformer construct a namePrefixTransformer with defaultNamePrefixPathConfigs. func NewDefaultingNamePrefixTransformer(nameprefix string) (Transformer, error) { return NewNamePrefixTransformer(defaultNamePrefixPathConfigs, nameprefix) @@ -83,6 +89,9 @@ func (o *namePrefixTransformer) Transform(m resmap.ResMap) error { } for id := range mf { + if selectByGVK(id.Gvk(), deprecateNamePrefixPathConfig.GroupVersionKind) { + log.Println("Adding nameprefix to Namespace resource will be deprecated in next release.") + } objMap := mf[id].UnstructuredContent() for _, path := range o.pathConfigs { if !selectByGVK(id.Gvk(), path.GroupVersionKind) {