kubernetes-sigs/kustomize
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/kustomize.git synced 2026-06-11 17:12:51 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Move repeated variable content to constants following linter suggestion

Browse Source
This commit is contained in:
Arthur Mello
2019-12-07 18:45:37 -03:00
parent f0779cd02f
commit 0bace652c3
2 changed files with 29 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
kyaml/runfn/runfn_test.go
View File

@@ -18,6 +18,18 @@ import (
"sigs.k8s.io/kustomize/kyaml/yaml"
)
const (
ValueReplacerYAMLData = `apiVersion: v1
kind: ValueReplacer
metadata:
configFn:
container:
image: gcr.io/example.com/image:version
stringMatch: Deployment
replace: StatefulSet
`
)
func TestRunFns_Execute(t *testing.T) {
instance := RunFns{}
instance.init()
@@ -28,7 +40,7 @@ kind:
return
}
filter := instance.containerFilterProvider("example.com:version", "", api)
defaultMount:= filters.StorageMount{}
defaultMount := filters.StorageMount{}
mounts := []filters.StorageMount{}
mounts = append(mounts, defaultMount)
assert.Equal(t, &filters.ContainerFilter{Image: "example.com:version", Config: api, StorageMounts: mounts}, filter)
@@ -57,17 +69,8 @@ func TestCmd_Execute(t *testing.T) {
}
// write a test filter
f := `apiVersion: v1
kind: ValueReplacer
metadata:
configFn:
container:
image: gcr.io/example.com/image:version
stringMatch: Deployment
replace: StatefulSet
`
if !assert.NoError(t, ioutil.WriteFile(
filepath.Join(dir, "filter.yaml"), []byte(f), 0600)) {
filepath.Join(dir, "filter.yaml"), []byte(ValueReplacerYAMLData), 0600)) {
return
}
@@ -126,21 +129,12 @@ func TestCmd_Execute_APIs(t *testing.T) {
}
// write a test filter
f := `apiVersion: v1
kind: ValueReplacer
metadata:
configFn:
container:
image: gcr.io/example.com/image:version
stringMatch: Deployment
replace: StatefulSet
`
tmpF, err := ioutil.TempFile("", "filter*.yaml")
if !assert.NoError(t, err) {
return
}
os.RemoveAll(tmpF.Name())
if !assert.NoError(t, ioutil.WriteFile(tmpF.Name(), []byte(f), 0600)) {
if !assert.NoError(t, ioutil.WriteFile(tmpF.Name(), []byte(ValueReplacerYAMLData), 0600)) {
return
}
@@ -201,17 +195,8 @@ func TestCmd_Execute_Stdout(t *testing.T) {
}
// write a test filter
f := `apiVersion: v1
kind: ValueReplacer
metadata:
configFn:
container:
image: gcr.io/example.com/image:version
stringMatch: Deployment
replace: StatefulSet
`
if !assert.NoError(t, ioutil.WriteFile(
filepath.Join(dir, "filter.yaml"), []byte(f), 0600)) {
filepath.Join(dir, "filter.yaml"), []byte(ValueReplacerYAMLData), 0600)) {
return
}