kubernetes-sigs/kustomize
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/kustomize.git synced 2026-06-11 17:12:51 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Skip in-memory tests for Windows and generate temporary directories correctly for Windows tests.

Browse Source
This commit is contained in:
Francesc Campoy
2021-07-26 16:43:57 -07:00
parent 6db2bf69f3
commit 0fa056327a
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
kyaml/kio/pkgio_writer_test.go
View File

@@ -6,7 +6,9 @@ package kio_test
import ( import (
"fmt" "fmt"
"math/rand" "math/rand"
"os"
"path/filepath" "path/filepath"
"runtime"
"testing" "testing"
"time" "time"
@@ -282,7 +284,10 @@ metadata:
func testWriterOnDiskAndOnMem(t *testing.T, f func(t *testing.T, fs filesys.FileSystem)) { func testWriterOnDiskAndOnMem(t *testing.T, f func(t *testing.T, fs filesys.FileSystem)) {
t.Run("on_disk", func(t *testing.T) { f(t, filesys.MakeFsOnDisk()) }) t.Run("on_disk", func(t *testing.T) { f(t, filesys.MakeFsOnDisk()) })
t.Run("on_mem", func(t *testing.T) { f(t, filesys.MakeFsInMemory()) }) // TODO: Once fsnode supports Windows, these tests should also be run.
if runtime.GOOS != "windows" {
t.Run("on_mem", func(t *testing.T) { f(t, filesys.MakeFsInMemory()) })
}
} }
func getWriterInputs(t *testing.T, mockFS filesys.FileSystem) (string, *yaml.RNode, *yaml.RNode, *yaml.RNode, func()) { func getWriterInputs(t *testing.T, mockFS filesys.FileSystem) (string, *yaml.RNode, *yaml.RNode, *yaml.RNode, func()) {
@@ -312,8 +317,9 @@ metadata:
`) `)
require.NoError(t, err) require.NoError(t, err)
// These two lines are similar to calling ioutil.TempDir, but we don't actually create any directory.
rand.Seed(time.Now().Unix()) rand.Seed(time.Now().Unix())
path := fmt.Sprintf("/tmp/kyaml-test%d", rand.Int31()) path := filepath.Join(os.TempDir(), fmt.Sprintf("kyaml-test%d", rand.Int31()))
require.NoError(t, mockFS.MkdirAll(filepath.Join(path, "a"))) require.NoError(t, mockFS.MkdirAll(filepath.Join(path, "a")))
return path, node1, node2, node3, func() { require.NoError(t, mockFS.RemoveAll(path)) } return path, node1, node2, node3, func() { require.NoError(t, mockFS.RemoveAll(path)) }
} }