kubernetes-sigs/kustomize
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/kustomize.git synced 2026-06-11 00:52:55 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Added code for fields with dots(.) in their names work as needed (#4591)

Browse Source 
* Added code for fields with dots(.) in their names work as needed

Co-authored-by: sarjamil <sjamil@salesforce.com>

* Fixed imports

Co-authored-by: sarjamil <sjamil@salesforce.com>

* Removed comments

Co-authored-by: sarjamil <sjamil@salesforce.com>

* Fix filter method

Co-authored-by: sarjamil <sjamil@salesforce.com>

* Fixed failing tests

Co-authored-by: sarjamil <sjamil@salesforce.com>

* Remove comments

Add co-author to PR.

Co-authored-by: sarjamil <sjamil@salesforce.com>

* Add co-author to PR.

Co-authored-by: sarjamil sjamil@salesforce.com

Co-authored-by: sarjamil <sjamil@salesforce.com>
This commit is contained in:
annelausf
2022-05-02 14:30:33 -07:00
committed by GitHub
parent 233b6adf7e
commit 188e35fbfd
6 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
kyaml/yaml/rnode_test.go
View File

@@ -2310,8 +2310,6 @@ func TestGetAnnotations(t *testing.T) {
}
func TestGetFieldValueWithDot(t *testing.T) {
t.Skip()
const input = `
kind: Pod
metadata:
@@ -2330,8 +2328,6 @@ metadata:
require.NoError(t, err)
require.Equal(t, "hello-world-app", app)
// TODO: doesn't currently work; we expect to be able to escape the dot in future
// https://github.com/kubernetes-sigs/kustomize/issues/4487
fooAppName, err := labelRNode.GetFieldValue(`foo\.appname`)
require.NoError(t, err)
require.Equal(t, "hello-world-foo", fooAppName) // no field named 'foo.appname'