From 1a5aa63d542e10c23fdcc4d9e70b4f67fe63a73d Mon Sep 17 00:00:00 2001 From: jregan Date: Fri, 4 Dec 2020 12:29:39 -0800 Subject: [PATCH] Spelling nits. --- api/builtins/HelmChartInflationGenerator.go | 4 +--- api/internal/validate/fieldvalidator.go | 4 ++++ api/resource/doc.go | 5 +++++ api/resource/resource.go | 1 - .../PatchStrategicMergeTransformer_test.go | 2 +- 5 files changed, 11 insertions(+), 5 deletions(-) create mode 100644 api/resource/doc.go diff --git a/api/builtins/HelmChartInflationGenerator.go b/api/builtins/HelmChartInflationGenerator.go index 8aa8340e5..78150aef4 100644 --- a/api/builtins/HelmChartInflationGenerator.go +++ b/api/builtins/HelmChartInflationGenerator.go @@ -1,8 +1,6 @@ // Code generated by pluginator on HelmChartInflationGenerator; DO NOT EDIT. // pluginator {unknown 1970-01-01T00:00:00Z } - - package builtins import ( @@ -177,5 +175,5 @@ func (p *HelmChartInflationGeneratorPlugin) checkHelmVersion() error { } func NewHelmChartInflationGeneratorPlugin() resmap.GeneratorPlugin { - return &HelmChartInflationGeneratorPlugin{} + return &HelmChartInflationGeneratorPlugin{} } diff --git a/api/internal/validate/fieldvalidator.go b/api/internal/validate/fieldvalidator.go index c9e47fa3e..5ccfc3ce7 100644 --- a/api/internal/validate/fieldvalidator.go +++ b/api/internal/validate/fieldvalidator.go @@ -10,6 +10,10 @@ import ( // FieldValidator implements ifc.Validator to check // the values of various KRM string fields, // e.g. labels, annotations, names, namespaces. +// +// TODO: Have this use kyaml/yaml/internal/k8sgen/pkg/labels +// which has label and annotation validation code, but is internal +// so this impl would need to move to kyaml (a fine idea). type FieldValidator struct { } diff --git a/api/resource/doc.go b/api/resource/doc.go new file mode 100644 index 000000000..32d34b162 --- /dev/null +++ b/api/resource/doc.go @@ -0,0 +1,5 @@ +// Copyright 2020 The Kubernetes Authors. +// SPDX-License-Identifier: Apache-2.0 + +// Package resource implements representations of k8s API resources. +package resource diff --git a/api/resource/resource.go b/api/resource/resource.go index 38e5d7c9b..8376124ad 100644 --- a/api/resource/resource.go +++ b/api/resource/resource.go @@ -1,7 +1,6 @@ // Copyright 2019 The Kubernetes Authors. // SPDX-License-Identifier: Apache-2.0 -// Package resource implements representations of k8s API resources. package resource import ( diff --git a/plugin/builtin/patchstrategicmergetransformer/PatchStrategicMergeTransformer_test.go b/plugin/builtin/patchstrategicmergetransformer/PatchStrategicMergeTransformer_test.go index c6e5ad809..189d8e057 100644 --- a/plugin/builtin/patchstrategicmergetransformer/PatchStrategicMergeTransformer_test.go +++ b/plugin/builtin/patchstrategicmergetransformer/PatchStrategicMergeTransformer_test.go @@ -1031,7 +1031,7 @@ type testRecord struct { // TestMultiplePatches checks that the patches are applied // properly, that the same result is obtained, // regardless of the order of the patches and regardless -// of the schema availibility (SMP vs JSON) +// of the schema availability (SMP vs JSON) func TestMultiplePatches(t *testing.T) { tests := map[string]testRecord{ "withschema-label-image-container": {