Further isolate unstructured with factories.

pkg/resource/resource_test.go

@@ -17,12 +17,9 @@ limitations under the License.
 package resource
 
 import (
-	"reflect"
 	"testing"
 
 	"sigs.k8s.io/kustomize/internal/k8sdeps"
-	"sigs.k8s.io/kustomize/pkg/internal/loadertest"
-	"sigs.k8s.io/kustomize/pkg/patch"
 )
 
 var factory = NewFactory(
@@ -70,78 +67,3 @@ func TestResourceString(t *testing.T) {
 		}
 	}
 }
-
-func TestSliceFromPatches(t *testing.T) {
-
-	patchGood1 := patch.StrategicMerge("/foo/patch1.yaml")
-	patch1 := `
-apiVersion: apps/v1
-kind: Deployment
-metadata:
-  name: pooh
-`
-	patchGood2 := patch.StrategicMerge("/foo/patch2.yaml")
-	patch2 := `
-apiVersion: v1
-kind: ConfigMap
-metadata:
-  name: winnie
----
-# some comment
----
----
-`
-	patchBad := patch.StrategicMerge("/foo/patch3.yaml")
-	patch3 := `
-WOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOT: woot
-`
-	l := loadertest.NewFakeLoader("/foo")
-	l.AddFile(string(patchGood1), []byte(patch1))
-	l.AddFile(string(patchGood2), []byte(patch2))
-	l.AddFile(string(patchBad), []byte(patch3))
-
-	tests := []struct {
-		name        string
-		input       []patch.StrategicMerge
-		expectedOut []*Resource
-		expectedErr bool
-	}{
-		{
-			name:        "happy",
-			input:       []patch.StrategicMerge{patchGood1, patchGood2},
-			expectedOut: []*Resource{testDeployment, testConfigMap},
-			expectedErr: false,
-		},
-		{
-			name:        "badFileName",
-			input:       []patch.StrategicMerge{patchGood1, "doesNotExist"},
-			expectedOut: []*Resource{},
-			expectedErr: true,
-		},
-		{
-			name:        "badData",
-			input:       []patch.StrategicMerge{patchGood1, patchBad},
-			expectedOut: []*Resource{},
-			expectedErr: true,
-		},
-	}
-	for _, test := range tests {
-		rs, err := factory.SliceFromPatches(l, test.input)
-		if test.expectedErr && err == nil {
-			t.Fatalf("%v: should return error", test.name)
-		}
-		if !test.expectedErr && err != nil {
-			t.Fatalf("%v: unexpected error: %s", test.name, err)
-		}
-		if len(rs) != len(test.expectedOut) {
-			t.Fatalf("%s: length mismatch %d != %d",
-				test.name, len(rs), len(test.expectedOut))
-		}
-		for i := range rs {
-			if !reflect.DeepEqual(test.expectedOut[i], rs[i]) {
-				t.Fatalf("%s: Got: %v\nexpected:%v",
-					test.name, test.expectedOut[i], rs[i])
-			}
-		}
-	}
-}