From 21a0cba43e5cc9960fd60f0b3df260d19d26648c Mon Sep 17 00:00:00 2001 From: Jingfang Liu Date: Fri, 29 Mar 2019 13:10:11 -0700 Subject: [PATCH] fix the regression of building remote url (#935) --- examples/remoteBuild.md | 2 +- pkg/git/cloner.go | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/examples/remoteBuild.md b/examples/remoteBuild.md index 747724fca..1e3a42ac7 100644 --- a/examples/remoteBuild.md +++ b/examples/remoteBuild.md @@ -10,7 +10,7 @@ Running `kustomize build` against the url gives the same output. ``` -target=github.com/kubernetes-sigs/kustomize//examples/multibases?ref=v1.0.6 +target=github.com/kubernetes-sigs/kustomize//examples/multibases test 3 == \ $(kustomize build $target | grep cluster-a-.*-myapp-pod | wc -l); \ echo $? diff --git a/pkg/git/cloner.go b/pkg/git/cloner.go index cbf176448..f5d92418f 100644 --- a/pkg/git/cloner.go +++ b/pkg/git/cloner.go @@ -68,9 +68,8 @@ func ClonerUsingGitExec(repoSpec *RepoSpec) error { "trouble adding remote %s", repoSpec.CloneSpec()) } - if repoSpec.ref == "" { - return nil + repoSpec.ref = "master" } cmd = exec.Command( gitProgram,