kubernetes-sigs/kustomize
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/kustomize.git synced 2026-06-11 17:12:51 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

update the pr to handle the case when the setter to be deleted is used in substitution

Browse Source
This commit is contained in:
Jijie Wei
2020-05-26 17:22:04 -07:00
parent fb6830c98a
commit 22a6017870
8 changed files with 864 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
kyaml/fieldmeta/fieldmeta.go
View File

@@ -151,10 +151,16 @@ func (fm *FieldMeta) Write(n *yaml.RNode) error {
delete(fm.Schema.VendorExtensible.Extensions, "x-kustomize")
}
// Ex: {"$ref":"#/definitions/io.k8s.cli.setters.replicas"} should be converted to
// {"openAPI":"replicas"} and added to the line comment
arr := strings.Split(fm.Schema.Ref.String(), ".")
n.YNode().LineComment = fmt.Sprintf(`{"%s":"%s"}`, shortHandRef, arr[len(arr)-1])
// Ref is removed when a setter is deleted, so the Ref string could be empty.
if fm.Schema.Ref.String() != "" {
// Ex: {"$ref":"#/definitions/io.k8s.cli.setters.replicas"} should be converted to
// {"openAPI":"replicas"} and added to the line comment
arr := strings.Split(fm.Schema.Ref.String(), ".")
n.YNode().LineComment = fmt.Sprintf(`{"%s":"%s"}`, shortHandRef, arr[len(arr)-1])
} else {
n.YNode().LineComment = ""
}
return nil
}