update the pr to handle the case when the setter to be deleted is used in substitution

kyaml/setters2/settersutil/deletercreator.go

@@ -0,0 +1,42 @@
+// Copyright 2019 The Kubernetes Authors.
+// SPDX-License-Identifier: Apache-2.0
+
+package settersutil
+
+import (
+	"sigs.k8s.io/kustomize/kyaml/kio"
+	"sigs.k8s.io/kustomize/kyaml/openapi"
+	"sigs.k8s.io/kustomize/kyaml/setters2"
+)
+
+// DeleterCreator delete a setter in the OpenAPI definitions, and removes references
+// to the setter from matching resource fields.
+type DeleterCreator struct {
+	// Name is the name of the setter to create or update.
+	Name string
+}
+
+func (d DeleterCreator) Delete(openAPIPath, resourcesPath string) error {
+	dd := setters2.DeleterDefinition{
+		Name: d.Name,
+	}
+	if err := dd.DeleteFromFile(openAPIPath); err != nil {
+		return err
+	}
+
+	// Load the updated definitions
+	if err := openapi.AddSchemaFromFile(openAPIPath); err != nil {
+		return err
+	}
+
+	// Update the resources with the deleter reference
+	inout := &kio.LocalPackageReadWriter{PackagePath: resourcesPath}
+	return kio.Pipeline{
+		Inputs: []kio.Reader{inout},
+		Filters: []kio.Filter{kio.FilterAll(
+			&setters2.Delete{
+				FieldName: d.Name,
+			})},
+		Outputs: []kio.Writer{inout},
+	}.Execute()
+}