mirror of
https://github.com/kubernetes-sigs/kustomize.git
synced 2026-06-12 01:14:22 +00:00
fix: performance recession when propagating namespace to helm (#5971)
* fix: performance recession when propagating namespace to helm * fix: handle passing namespace downstream more elegant * Revert "fix: handle passing namespace downstream more elegant" This reverts commit976a7cf2aa. * Revert "fix: performance recession when propagating namespace to helm" This reverts commitc7612d1dba. * fix: use annotation to identify helm chart generated resources * fix: deduplicate code * fix: missing import in NamespaceTransformer.go * ci: allow manual trigger of pipeline in fork * Revert "ci: allow manual trigger of pipeline in fork" This reverts commit8948788fe2. * fix: test cases * chore: fix code comment was on wrong line * chore: fix code comment was on wrong line pt2
This commit is contained in:
@@ -9,9 +9,9 @@ import (
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
"sigs.k8s.io/kustomize/api/konfig"
|
||||
"sigs.k8s.io/kustomize/api/provider"
|
||||
"sigs.k8s.io/kustomize/api/resmap"
|
||||
"sigs.k8s.io/kustomize/api/resource"
|
||||
kusttest_test "sigs.k8s.io/kustomize/api/testutils/kusttest"
|
||||
kyaml "sigs.k8s.io/kustomize/kyaml/yaml"
|
||||
)
|
||||
@@ -779,15 +779,12 @@ kind: Service
|
||||
metadata:
|
||||
name: svc
|
||||
namespace: helm-ns
|
||||
annotations:
|
||||
this-should-be-keept: "true"
|
||||
`))
|
||||
require.NoError(t, err)
|
||||
r := rm.Resources()[0]
|
||||
origin := &resource.Origin{
|
||||
ConfiguredBy: kyaml.ResourceIdentifier{
|
||||
TypeMeta: kyaml.TypeMeta{APIVersion: "builtin", Kind: "HelmChartInflationGenerator"},
|
||||
},
|
||||
}
|
||||
require.NoError(t, r.SetOrigin(origin))
|
||||
require.NoError(t, r.RNode.PipeE(kyaml.SetAnnotation(konfig.HelmGeneratedAnnotation, "true")))
|
||||
|
||||
rm, err = th.RunTransformerFromResMap(`
|
||||
apiVersion: builtin
|
||||
@@ -801,6 +798,8 @@ metadata:
|
||||
th.AssertActualEqualsExpectedNoIdAnnotations(rm, `apiVersion: v1
|
||||
kind: Service
|
||||
metadata:
|
||||
annotations:
|
||||
this-should-be-keept: "true"
|
||||
name: svc
|
||||
namespace: helm-ns
|
||||
`)
|
||||
|
||||
Reference in New Issue
Block a user