Add test for builtin secretgenerator plugin.

plugin/builtin/SecretGenerator.go

@@ -18,28 +18,16 @@ type plugin struct {
 var KustomizePlugin plugin
 
 func (p *plugin) Config(
-	ldr ifc.Loader, rf *resmap.Factory, k ifc.Kunstructured) error {
+	ldr ifc.Loader, rf *resmap.Factory, k ifc.Kunstructured) (err error) {
 	p.ldr = ldr
 	p.rf = rf
-	var err error
-	// TODO: validate behavior values.
-	p.args.Behavior, err = k.GetFieldValue("behavior")
+	p.args.GeneratorArgs, err = resmap.GeneratorArgsFromKunstruct(k)
 	if err != nil {
-		return err
+		return
 	}
-	p.args.EnvSources, err = k.GetStringSlice("envFiles")
-	if err != nil {
-		return err
-	}
-	p.args.FileSources, err = k.GetStringSlice("valueFiles")
-	if err != nil {
-		return err
-	}
-	p.args.LiteralSources, err = k.GetStringSlice("literals")
-	if err != nil {
-		return err
-	}
-	return nil
+	// Ignore missing type - it defaults.
+	p.args.Type, _ = k.GetFieldValue("type")
+	return
 }
 
 func (p *plugin) Generate() (resmap.ResMap, error) {

plugin/builtin/SecretGenerator_test.go

@@ -0,0 +1,62 @@
+package builtin
+
+import (
+	"testing"
+
+	"sigs.k8s.io/kustomize/internal/plugintest"
+	"sigs.k8s.io/kustomize/k8sdeps/kv/plugin"
+	"sigs.k8s.io/kustomize/pkg/kusttest"
+	"sigs.k8s.io/kustomize/pkg/loader"
+)
+
+func TestSecretGenerator(t *testing.T) {
+	tc := plugintest_test.NewPluginTestEnv(t).Set()
+	defer tc.Reset()
+
+	tc.BuildGoPlugin(
+		"builtin", "", "SecretGenerator")
+
+	th := kusttest_test.NewKustTestHarnessFull(
+		t, "/app", loader.RestrictionRootOnly, plugin.ActivePluginConfig())
+
+	th.WriteF("/app/a.env", `
+ROUTER_PASSWORD=admin
+`)
+	th.WriteF("/app/b.env", `
+DB_PASSWORD=iloveyou
+`)
+	th.WriteF("/app/longsecret.txt", `
+Lorem ipsum dolor sit amet,
+consectetur adipiscing elit.
+`)
+
+	rm := th.LoadAndRunGenerator(`
+apiVersion: builtin
+kind: SecretGenerator
+metadata:
+  name: mySecret
+behavior: merge
+envFiles:
+- a.env
+- b.env
+valueFiles:
+- obscure=longsecret.txt
+literals:
+- FRUIT=apple
+- VEGETABLE=carrot
+`)
+
+	th.AssertActualEqualsExpected(rm, `
+apiVersion: v1
+data:
+  DB_PASSWORD: aWxvdmV5b3U=
+  FRUIT: YXBwbGU=
+  ROUTER_PASSWORD: YWRtaW4=
+  VEGETABLE: Y2Fycm90
+  obscure: CkxvcmVtIGlwc3VtIGRvbG9yIHNpdCBhbWV0LApjb25zZWN0ZXR1ciBhZGlwaXNjaW5nIGVsaXQuCg==
+kind: Secret
+metadata:
+  name: mySecret
+type: Opaque
+`)
+}