kubernetes-sigs/kustomize
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/kustomize.git synced 2026-06-13 01:50:55 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Fix pseudo git HTTP urls broken since 59c82659 (#4453)

Browse Source 
* Fix pseudo git HTTP urls broken since 59c82659

Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>

* Add test for Git resources using HTTP URLs

Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
This commit is contained in:
Sylvain Rabot
2022-02-09 23:23:49 +01:00
committed by GitHub
parent 14cb815b5d
commit 2f17803c0a
2 changed files with 66 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

60
api/krusty/remoteload_test.go
View File

@@ -77,6 +77,66 @@ spec:
assert.NoError(t, fSys.RemoveAll(tmpDir.String()))
}
func TestRemoteResourceGitHTTP(t *testing.T) {
output := `apiVersion: v1
kind: Pod
metadata:
labels:
app: myapp
name: dev-myapp-pod
spec:
containers:
- image: nginx:1.7.9
name: nginx
`
tests := []struct {
input []byte
}{
{
input: []byte(`
resources:
- https://github.com/kubernetes-sigs/kustomize/examples/multibases/dev/?ref=v1.0.6
`),
},
{
input: []byte(`
resources:
- https://github.com/kubernetes-sigs/kustomize//examples/multibases/dev/?ref=v1.0.6
`),
},
{
input: []byte(`
resources:
- git::https://github.com/kubernetes-sigs/kustomize/examples/multibases/dev/?ref=v1.0.6
`),
},
{
input: []byte(`
resources:
- git::https://github.com/kubernetes-sigs/kustomize//examples/multibases/dev/?ref=v1.0.6
`),
},
}
for _, test := range tests {
fSys := filesys.MakeFsOnDisk()
b := krusty.MakeKustomizer(krusty.MakeDefaultOptions())
tmpDir, err := filesys.NewTmpConfirmedDir()
assert.NoError(t, err)
assert.NoError(t, fSys.WriteFile(filepath.Join(tmpDir.String(), "kustomization.yaml"), test.input))
m, err := b.Run(fSys, tmpDir.String())
if utils.IsErrTimeout(err) {
// Don't fail on timeouts.
t.SkipNow()
}
assert.NoError(t, err)
yml, err := m.AsYaml()
assert.NoError(t, err)
assert.Equal(t, output, string(yml))
assert.NoError(t, fSys.RemoveAll(tmpDir.String()))
}
}
func TestRemoteResourceWithHTTPError(t *testing.T) {
fSys := filesys.MakeFsOnDisk()
b := krusty.MakeKustomizer(krusty.MakeDefaultOptions())