kubernetes-sigs/kustomize
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/kustomize.git synced 2026-06-13 10:00:56 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Fix unused error value

Browse Source 
The linter was complaining about err being unchecked.
This commit is contained in:
justinsb
2023-03-20 14:19:16 +00:00
parent a2e9682002
commit 317fcadccb
2 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
api/internal/builtins/HelmChartInflationGenerator.go
View File

@@ -262,15 +262,18 @@ func (p *HelmChartInflationGeneratorPlugin) Generate() (rm resmap.ResMap, err er
// helm may produce messages to stdout before it // helm may produce messages to stdout before it
r := &kio.ByteReader{Reader: bytes.NewBufferString(string(stdout)), OmitReaderAnnotations: true} r := &kio.ByteReader{Reader: bytes.NewBufferString(string(stdout)), OmitReaderAnnotations: true}
nodes, err := r.Read() nodes, err := r.Read()
if err != nil {
return nil, fmt.Errorf("error reading helm output: %w", err)
}
if len(nodes) != 0 { if len(nodes) != 0 {
rm, err = p.h.ResmapFactory().NewResMapFromRNodeSlice(nodes) rm, err = p.h.ResmapFactory().NewResMapFromRNodeSlice(nodes)
if err != nil { if err != nil {
return nil, fmt.Errorf("could not parse rnode slice into resource map: %w\n", err) return nil, fmt.Errorf("could not parse rnode slice into resource map: %w", err)
} }
return rm, nil return rm, nil
} }
return nil, fmt.Errorf("could not parse bytes into resource map: %w\n", resMapErr) return nil, fmt.Errorf("could not parse bytes into resource map: %w", resMapErr)
} }
func (p *HelmChartInflationGeneratorPlugin) pullCommand() []string { func (p *HelmChartInflationGeneratorPlugin) pullCommand() []string {

7
plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator.go
View File

@@ -268,15 +268,18 @@ func (p *plugin) Generate() (rm resmap.ResMap, err error) {
// helm may produce messages to stdout before it // helm may produce messages to stdout before it
r := &kio.ByteReader{Reader: bytes.NewBufferString(string(stdout)), OmitReaderAnnotations: true} r := &kio.ByteReader{Reader: bytes.NewBufferString(string(stdout)), OmitReaderAnnotations: true}
nodes, err := r.Read() nodes, err := r.Read()
if err != nil {
return nil, fmt.Errorf("error reading helm output: %w", err)
}
if len(nodes) != 0 { if len(nodes) != 0 {
rm, err = p.h.ResmapFactory().NewResMapFromRNodeSlice(nodes) rm, err = p.h.ResmapFactory().NewResMapFromRNodeSlice(nodes)
if err != nil { if err != nil {
return nil, fmt.Errorf("could not parse rnode slice into resource map: %w\n", err) return nil, fmt.Errorf("could not parse rnode slice into resource map: %w", err)
} }
return rm, nil return rm, nil
} }
return nil, fmt.Errorf("could not parse bytes into resource map: %w\n", resMapErr) return nil, fmt.Errorf("could not parse bytes into resource map: %w", resMapErr)
} }
func (p *plugin) pullCommand() []string { func (p *plugin) pullCommand() []string {