From 341bacb9a24a25c4c87f48ad22c908480eff0302 Mon Sep 17 00:00:00 2001 From: Justin SB Date: Fri, 11 Sep 2020 11:39:49 -0400 Subject: [PATCH] Fix comment on SplitIndexNameValue It was incorrect and suggested some behaviour which isn't present. Added test to verify the documented behaviour. --- kyaml/yaml/fns.go | 2 +- kyaml/yaml/fns_test.go | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/kyaml/yaml/fns.go b/kyaml/yaml/fns.go index dbb122e46..ffc1e4d6f 100644 --- a/kyaml/yaml/fns.go +++ b/kyaml/yaml/fns.go @@ -605,7 +605,7 @@ func IsListIndex(p string) bool { // SplitIndexNameValue splits a lookup part Val index into the field name // and field value to match. // e.g. splits [name=nginx] into (name, nginx) -// e.g. splits [=-jar] into ("", jar) +// e.g. splits [=-jar] into ("", -jar) func SplitIndexNameValue(p string) (string, string, error) { elem := strings.TrimSuffix(p, "]") elem = strings.TrimPrefix(elem, "[") diff --git a/kyaml/yaml/fns_test.go b/kyaml/yaml/fns_test.go index 963e00166..ad5b9937b 100644 --- a/kyaml/yaml/fns_test.go +++ b/kyaml/yaml/fns_test.go @@ -518,6 +518,11 @@ func TestSplitIndexNameValue(t *testing.T) { assert.NoError(t, err) assert.Equal(t, "a", k) assert.Equal(t, "b=c", v) + + k, v, err = SplitIndexNameValue("=-jar") + assert.NoError(t, err) + assert.Equal(t, "", k) + assert.Equal(t, "-jar", v) } type filter struct {