From 9abd0119e1f4c3e517b4b33cb583277d8d44225a Mon Sep 17 00:00:00 2001 From: Natasha Sarkar Date: Fri, 18 Sep 2020 14:30:18 -0700 Subject: [PATCH 1/2] test for issue 2896 --- api/krusty/issue2896_test.go | 106 +++++++++++++++++++++++++++++++++++ 1 file changed, 106 insertions(+) create mode 100644 api/krusty/issue2896_test.go diff --git a/api/krusty/issue2896_test.go b/api/krusty/issue2896_test.go new file mode 100644 index 000000000..8f2e32aeb --- /dev/null +++ b/api/krusty/issue2896_test.go @@ -0,0 +1,106 @@ +// Copyright 2019 The Kubernetes Authors. +// SPDX-License-Identifier: Apache-2.0 + +package krusty_test + +import ( + "testing" + + kusttest_test "sigs.k8s.io/kustomize/api/testutils/kusttest" +) + +func writeIssueBase(th kusttest_test.Harness) { + th.WriteK("base", ` +nameSuffix: -test-api + +resources: + - deploy.yaml +`) + th.WriteF("base/deploy.yaml", ` +apiVersion: apps/v1 +kind: Deployment +metadata: + name: example +spec: + template: + spec: + containers: + - name: example + image: example:1.0 + volumeMounts: + - name: conf + mountPath: /etc/config + volumes: + - name: conf + configMap: + name: conf +`) +} + +func TestIssue2896Base(t *testing.T) { + th := kusttest_test.MakeHarness(t) + writeIssueBase(th) + m := th.Run(".", th.MakeDefaultOptions()) + th.AssertActualEqualsExpected(m, ` +apiVersion: apps/v1 +kind: Deployment +metadata: + name: example-test-api +spec: + template: + spec: + containers: + - image: example:1.0 + name: example + volumeMounts: + - mountPath: /etc/config + name: conf + volumes: + - configMap: + name: conf + name: conf +`) +} + +func TestIssue2896Overlay(t *testing.T) { + th := kusttest_test.MakeHarness(t) + writeIssueBase(th) + th.WriteK("overlay", ` +resources: + - ../base + +patches: + - patch: |- + apiVersion: apps/v1 + kind: Deployment + metadata: + name: example + spec: + template: + spec: + containers: + - name: example + image: example:2.0 +`) + + m := th.Run("overlay", th.MakeDefaultOptions()) + th.AssertActualEqualsExpected(m, ` +apiVersion: apps/v1 +kind: Deployment +metadata: + name: example +spec: + template: + spec: + containers: + - image: example:2.0 + name: example + volumeMounts: + - mountPath: /etc/config + name: conf + volumes: + - configMap: + name: conf + name: conf +`) +} From ce0dba9217322438c3b602a630cba65502f22ebe Mon Sep 17 00:00:00 2001 From: Natasha Sarkar Date: Mon, 21 Sep 2020 11:32:26 -0700 Subject: [PATCH 2/2] fixed bug in base test --- api/krusty/issue2896_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/krusty/issue2896_test.go b/api/krusty/issue2896_test.go index 8f2e32aeb..524e8a1a3 100644 --- a/api/krusty/issue2896_test.go +++ b/api/krusty/issue2896_test.go @@ -40,7 +40,7 @@ spec: func TestIssue2896Base(t *testing.T) { th := kusttest_test.MakeHarness(t) writeIssueBase(th) - m := th.Run(".", th.MakeDefaultOptions()) + m := th.Run("base", th.MakeDefaultOptions()) th.AssertActualEqualsExpected(m, ` apiVersion: apps/v1 kind: Deployment