From 3ac8575ed87ed29bfa02011be71a23000706253e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hannes=20H=C3=B6rl?= Date: Wed, 29 Nov 2017 15:14:33 +0000 Subject: [PATCH] Make `pre-commit.sh` work with the test framework Eventually we want our framework to work nicely with just `go test`. To get there we need to - inject KUBE_ASSETS_DIR - make the framework work when run multiple times in parallel (port collitions, expose bound ports the the subject under test, ...) We decided to make sure our tests are run in sequence (and not in parallel to any other thing using etcd, for that matter) by making this explicit in the `pre-commit.sh` - for now. As soon as we are there, we can rollback the change to the `pre-commit.sh` end have the test framework be tested the same as everything else. [#153248975] --- pre-commit.sh | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pre-commit.sh b/pre-commit.sh index c81e9ca08..fc519568e 100755 --- a/pre-commit.sh +++ b/pre-commit.sh @@ -19,7 +19,12 @@ go vet -all ./... rc=$((rc || $?)) echo "Running go test" -go test -v ./... +go list ./... | grep -vF pkg/framework/test | xargs go test -v +rc=$((rc || $?)) + +echo "Running test framework tests" +./pkg/framework/test/scripts/download-binaries.sh \ + && ./pkg/framework/test/scripts/run-tests.sh rc=$((rc || $?)) exit $rc