Add diamond base test.

This commit is contained in:
Jeffrey Regan
2019-06-27 15:22:21 -07:00
parent 0877aa7e0b
commit 3cef37bdb2
3 changed files with 231 additions and 6 deletions

View File

@@ -98,16 +98,17 @@ func (tf *transformer) Transform(m resmap.ResMap) error {
func (tf *transformer) findPatchTarget(
m resmap.ResMap, id resid.ResId) (*resource.Resource, error) {
match, err := m.GetByOriginalId(id)
if err == nil {
match, err1 := m.GetByOriginalId(id)
if err1 == nil {
return match, nil
}
match, err = m.GetByCurrentId(id)
if err == nil {
match, err2 := m.GetByCurrentId(id)
if err2 == nil {
return match, nil
}
return nil, fmt.Errorf(
"failed to find target for patch %s", id.GvknString())
"%s; %s; failed to find unique target for patch %s",
err1.Error(), err2.Error(), id.GvknString())
}
// mergePatches merge and index patches by OrgId.

View File

@@ -380,7 +380,7 @@ func TestPatchesWithWrongNamespace(t *testing.T) {
if err == nil {
t.Fatalf("did not get expected error")
}
if !strings.Contains(err.Error(), "failed to find target for patch") {
if !strings.Contains(err.Error(), "failed to find unique target for patch") {
t.Fatalf("expected error to contain %q but get %v", "failed to find target for patch", err)
}
}