mirror of
https://github.com/kubernetes-sigs/kustomize.git
synced 2026-05-23 23:37:00 +00:00
Refactor the PrefixSuffixTransformer into separate prefix- and suffix transformers (#4318)
* Refactor prefix filter into its own filter, decoupled from the prefixsuffix filter * Refactor prefix transformer into its own transformer, decoupled from the prefixsuffix transformer * Refactor suffix filter into its own filter, decoupled from the prefixsuffix filter * Refactor suffix transformer into its own transformer, decoupled from the prefixsuffix transformer * Add a default nameSuffix field spec in addition to the namePrefix * Remove the PrefixSuffixTransformer from the list of builtin transformers * Add a multi-transformer to builtinhelpers.TransformFactories * Remove the implementation of the prefixsuffixtransformer.PrefixSuffixTransformer * Resolve style and format related feedback from the pull request * Add test to test the legacy PrefixSuffixTransformer for BC purposes
This commit is contained in:
@@ -26,11 +26,10 @@ type plugin struct {
|
||||
//noinspection GoUnusedGlobalVariable
|
||||
var KustomizePlugin plugin
|
||||
|
||||
func (p *plugin) makePrefixSuffixPluginConfig(n string) ([]byte, error) {
|
||||
func (p *plugin) makePrefixPluginConfig(n string) ([]byte, error) {
|
||||
var s struct {
|
||||
Prefix string
|
||||
Suffix string
|
||||
FieldSpecs []types.FieldSpec
|
||||
Prefix string `json:"prefix,omitempty" yaml:"prefix,omitempty"`
|
||||
FieldSpecs []types.FieldSpec `json:"fieldSpecs,omitempty" yaml:"fieldSpecs,omitempty"`
|
||||
}
|
||||
s.Prefix = n + "-"
|
||||
s.FieldSpecs = []types.FieldSpec{
|
||||
@@ -44,11 +43,11 @@ func (p *plugin) Config(h *resmap.PluginHelpers, c []byte) error {
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
c, err = p.makePrefixSuffixPluginConfig(p.Name)
|
||||
c, err = p.makePrefixPluginConfig(p.Name)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
prefixer := builtins.NewPrefixSuffixTransformerPlugin()
|
||||
prefixer := builtins.NewPrefixTransformerPlugin()
|
||||
err = prefixer.Config(h, c)
|
||||
if err != nil {
|
||||
return errors.Wrapf(
|
||||
|
||||
Reference in New Issue
Block a user