From f3e4615a33dbc50dc669a85c5a0060cf9a7ceb13 Mon Sep 17 00:00:00 2001 From: Jingfang Liu Date: Thu, 11 Oct 2018 11:04:26 -0700 Subject: [PATCH] use FakeFileSystem in configmapandsecret tests --- .../k8sdeps/configmapandsecret/configmapfactory_test.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/internal/k8sdeps/configmapandsecret/configmapfactory_test.go b/internal/k8sdeps/configmapandsecret/configmapfactory_test.go index e64a247da..720241556 100644 --- a/internal/k8sdeps/configmapandsecret/configmapfactory_test.go +++ b/internal/k8sdeps/configmapandsecret/configmapfactory_test.go @@ -91,7 +91,7 @@ func TestConstructConfigMap(t *testing.T) { input: types.ConfigMapArgs{ Name: "envConfigMap", DataSources: types.DataSources{ - EnvSource: "../../../pkg/examplelayout/simple/instances/exampleinstance/configmap/app.env", + EnvSource: "configmap/app.env", }, }, expected: makeEnvConfigMap("envConfigMap"), @@ -101,7 +101,7 @@ func TestConstructConfigMap(t *testing.T) { input: types.ConfigMapArgs{ Name: "fileConfigMap", DataSources: types.DataSources{ - FileSources: []string{"../../../pkg/examplelayout/simple/instances/exampleinstance/configmap/app-init.ini"}, + FileSources: []string{"configmap/app-init.ini"}, }, }, expected: makeFileConfigMap("fileConfigMap"), @@ -118,8 +118,9 @@ func TestConstructConfigMap(t *testing.T) { }, } - // TODO: all tests should use a FakeFs - fSys := fs.MakeRealFS() + fSys := fs.MakeFakeFS() + fSys.WriteFile("configmap/app.env", []byte("DB_USERNAME=admin\nDB_PASSWORD=somepw\n")) + fSys.WriteFile("configmap/app-init.ini", []byte("FOO=bar\nBAR=baz\n")) f := NewConfigMapFactory(fSys, loader.NewFileLoader(fSys)) for _, tc := range testCases { cm, err := f.MakeConfigMap(&tc.input)