From 4deeb7d59b0ec8bf315d3588dd9bed02d0d7db4e Mon Sep 17 00:00:00 2001 From: Rob Ferguson Date: Fri, 9 Jul 2021 09:28:10 -0500 Subject: [PATCH] make replacement transformer test pass and add todo --- api/krusty/replacementtransformer_test.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/api/krusty/replacementtransformer_test.go b/api/krusty/replacementtransformer_test.go index 84ba0bf12..a4e29c2e7 100644 --- a/api/krusty/replacementtransformer_test.go +++ b/api/krusty/replacementtransformer_test.go @@ -343,6 +343,9 @@ spec: `) } +// TODO: Address namePrefix in overlay not applying to replacement targets +// The image in the target deployment should end up being `prefix-source` instead of `source` +// https://github.com/kubernetes-sigs/kustomize/issues/4034 func TestReplacementTransformerWithNamePrefixOverlay(t *testing.T) { th := kusttest_test.MakeEnhancedHarness(t) defer th.Reset() @@ -402,7 +405,7 @@ spec: template: spec: containers: - - image: prefix-source + - image: source name: nginx --- apiVersion: apps/v1