Add negative case for testing keyValuesFromLine

This commit is contained in:
chansuke
2023-10-17 23:55:04 +09:00
parent 81297df4ff
commit 50159d47c2

View File

@@ -70,14 +70,19 @@ func TestKeyValuesFromLines(t *testing.T) {
}, },
expectedErr: false, expectedErr: false,
}, },
// TODO: add negative testcases {
desc: "invalid UTF-8 content",
content: "Invalid UTF8 Content: \x80\x81",
expectedPairs: nil,
expectedErr: true,
},
} }
kvl := makeKvLoader(filesys.MakeFsInMemory()) kvl := makeKvLoader(filesys.MakeFsInMemory())
for _, test := range tests { for _, test := range tests {
pairs, err := kvl.keyValuesFromLines([]byte(test.content)) pairs, err := kvl.keyValuesFromLines([]byte(test.content))
if test.expectedErr && err == nil { if test.expectedErr && err == nil {
t.Fatalf("%s should not return error", test.desc) t.Fatalf("%s should return error", test.desc)
} }
if !reflect.DeepEqual(pairs, test.expectedPairs) { if !reflect.DeepEqual(pairs, test.expectedPairs) {
t.Errorf("%s should succeed, got:%v exptected:%v", test.desc, pairs, test.expectedPairs) t.Errorf("%s should succeed, got:%v exptected:%v", test.desc, pairs, test.expectedPairs)