From 59ce165355050c4dc1c5ce762c4330ce34863e2d Mon Sep 17 00:00:00 2001 From: Rhomel Chinsio Date: Fri, 24 Jan 2020 17:46:58 +0900 Subject: [PATCH] docs: comment brace support purpose --- api/builtins/ImageTagTransformer.go | 2 ++ plugin/builtin/imagetagtransformer/ImageTagTransformer.go | 2 ++ 2 files changed, 4 insertions(+) diff --git a/api/builtins/ImageTagTransformer.go b/api/builtins/ImageTagTransformer.go index 4754196c0..f7b2f0112 100644 --- a/api/builtins/ImageTagTransformer.go +++ b/api/builtins/ImageTagTransformer.go @@ -145,6 +145,8 @@ func (p *ImageTagTransformerPlugin) findContainers(obj map[string]interface{}) e func isImageMatched(s, t string) bool { // Tag values are limited to [a-zA-Z0-9_.{}-]. + // Some tools like Bazel rules_k8s allow tag patterns with {} characters. + // More info: https://github.com/bazelbuild/rules_k8s/pull/423 pattern, _ := regexp.Compile("^" + t + "(@sha256)?(:[a-zA-Z0-9_.{}-]*)?$") return pattern.MatchString(s) } diff --git a/plugin/builtin/imagetagtransformer/ImageTagTransformer.go b/plugin/builtin/imagetagtransformer/ImageTagTransformer.go index 54c0c07c9..0ed721192 100644 --- a/plugin/builtin/imagetagtransformer/ImageTagTransformer.go +++ b/plugin/builtin/imagetagtransformer/ImageTagTransformer.go @@ -149,6 +149,8 @@ func (p *plugin) findContainers(obj map[string]interface{}) error { func isImageMatched(s, t string) bool { // Tag values are limited to [a-zA-Z0-9_.{}-]. + // Some tools like Bazel rules_k8s allow tag patterns with {} characters. + // More info: https://github.com/bazelbuild/rules_k8s/pull/423 pattern, _ := regexp.Compile("^" + t + "(@sha256)?(:[a-zA-Z0-9_.{}-]*)?$") return pattern.MatchString(s) }