Fixed gocyclo warnings and added pre-commit hook

.travis.yml

@@ -12,6 +12,7 @@ before_install:
   - go get -u golang.org/x/tools/cmd/goimports
   - go get -u github.com/onsi/ginkgo/ginkgo
   - go get -u github.com/monopole/mdrip
+  - go get -u github.com/fzipp/gocyclo
 
 # Install must be set to prevent default `go get` to run.
 # The dependencies have already been vendored by `dep` so

bin/pre-commit.sh

@@ -31,6 +31,11 @@ function testGoFmt {
   diff <(echo -n) <(go_dirs | xargs -0 gofmt -s -d -l)
 }
 
+
+function testGoCyclo {
+  diff <(echo -n) <(go_dirs | xargs -0 gocyclo -over 15)
+}
+
 function testGoImports {
   diff -u <(echo -n) <(go_dirs | xargs -0 goimports -l)
 }
@@ -50,6 +55,7 @@ function testExamples {
 runTest testGoFmt
 runTest testGoImports
 runTest testGoVet
+runTest testGoCyclo
 runTest testGoTest
 runTest testExamples
 

pkg/commands/build_test.go

@@ -104,7 +104,12 @@ func TestBuild(t *testing.T) {
 	}
 
 	for _, testcaseName := range testcases.List() {
-		t.Run(testcaseName, func(t *testing.T) {
+		t.Run(testcaseName, func(t *testing.T) { runBuildTestCase(t, testcaseName, updateKustomizeExpected, fs) })
+	}
+
+}
+
+func runBuildTestCase(t *testing.T, testcaseName string, updateKustomizeExpected bool, fs fs.FileSystem) {
 	name := testcaseName
 	testcase := buildTestCase{}
 	testcaseDir := filepath.Join("testdata", "testcase-"+name)
@@ -146,7 +151,4 @@ func TestBuild(t *testing.T) {
 		ioutil.WriteFile(testcase.ExpectedStdout, actualBytes, 0644)
 	}
 
-		})
-	}
-
 }

pkg/commands/diff_test.go

@@ -74,6 +74,14 @@ func TestDiff(t *testing.T) {
 
 	for _, testcaseName := range testcases.List() {
 		t.Run(testcaseName, func(t *testing.T) {
+			runDiffTestCase(t, testcaseName, updateKustomizeExpected, fs,
+				noopDir, transformedDir, timestamp)
+		})
+	}
+}
+
+func runDiffTestCase(t *testing.T, testcaseName string, updateKustomizeExpected bool, fs fs.FileSystem,
+	noopDir, transformedDir, timestamp *regexp.Regexp) {
 	name := testcaseName
 	testcase := DiffTestCase{}
 	testcaseDir := filepath.Join("testdata", "testcase-"+name)
@@ -119,6 +127,4 @@ func TestDiff(t *testing.T) {
 		ioutil.WriteFile(testcase.ExpectedDiff, actualBytes, 0644)
 	}
 
-		})
-	}
 }