fix GetFieldValue cannot handle slice index

This commit is contained in:
Donny Xia
2021-01-13 14:11:26 -08:00
parent 79afd219a5
commit 64beee22e9
3 changed files with 37 additions and 18 deletions

View File

@@ -532,9 +532,6 @@ vars:
func TestVariablesAmbiguousWorkaround(t *testing.T) {
th := kusttest_test.MakeHarness(t)
opts := th.MakeDefaultOptions()
if opts.UseKyaml {
t.Skip("TODO(#3396)")
}
th.WriteK("dev", namespaceNeedInVarDevFolder)
th.WriteF("dev/elasticsearch-dev-service.yaml", namespaceNeedInVarDevResources)
th.WriteK("test", namespaceNeedInVarTestFolder)
@@ -591,10 +588,6 @@ vars:
// to the variable declarations allows to disambiguate the variables.
func TestVariablesDisambiguatedWithNamespace(t *testing.T) {
th := kusttest_test.MakeHarness(t)
opts := th.MakeDefaultOptions()
if opts.UseKyaml {
t.Skip("TODO(#3396)")
}
th.WriteK(".", namespaceNeedInVarMyAppWithNamespace)
th.WriteF("elasticsearch-dev-service.yaml", namespaceNeedInVarDevResources)
th.WriteF("elasticsearch-test-service.yaml", namespaceNeedInVarTestResources)

View File

@@ -360,12 +360,11 @@ resources:
}
}
// TODO: varref has some quote issues
// https://github.com/kubernetes-sigs/kustomize/issues/3449
func TestVarRefBig(t *testing.T) {
th := kusttest_test.MakeHarness(t)
opts := th.MakeDefaultOptions()
if opts.UseKyaml {
t.Skip("TODO(#3396)")
}
th.WriteK("/app/base", `
namePrefix: base-
resources:
@@ -757,9 +756,9 @@ kind: Service
metadata:
annotations:
prometheus.io/path: _status/vars
prometheus.io/port: "8080"
prometheus.io/scrape: "true"
service.alpha.kubernetes.io/tolerate-unready-endpoints: "true"
prometheus.io/port: 8080
prometheus.io/scrape: true
service.alpha.kubernetes.io/tolerate-unready-endpoints: true
labels:
app: cockroachdb
name: dev-base-cockroachdb
@@ -770,8 +769,8 @@ spec:
port: 26257
targetPort: 26257
- name: http
port: 8080
targetPort: 8080
port: "8080"
targetPort: "8080"
selector:
app: cockroachdb
---
@@ -787,8 +786,8 @@ spec:
port: 26257
targetPort: 26257
- name: http
port: 8080
targetPort: 8080
port: "8080"
targetPort: "8080"
selector:
app: cockroachdb
---