drop unnecessary -f from diff

This commit is contained in:
Jeffrey Regan
2018-05-18 11:24:23 -07:00
parent 00cb01a222
commit 6662bb6cc7
3 changed files with 19 additions and 40 deletions

View File

@@ -40,43 +40,29 @@ func newCmdDiff(out, errOut io.Writer, fs fs.FileSystem) *cobra.Command {
var o diffOptions
cmd := &cobra.Command{
Use: "diff",
Short: "diff between transformed resources and untransformed resources",
Long: "diff between transformed resources and untransformed resources and the subpackages are all transformed.",
Example: `diff -f .`,
Use: "diff [path]",
Short: "diff between customized resources and uncustomized resources",
RunE: func(cmd *cobra.Command, args []string) error {
err := o.Validate(cmd, args)
if err != nil {
return err
}
err = o.Complete(cmd, args)
if err != nil {
return err
}
return o.RunDiff(out, errOut, fs)
},
}
cmd.Flags().StringVarP(
&o.kustomizationPath,
"filename",
"f",
"",
"Specify a directory containing "+constants.KustomizationFileName)
cmd.MarkFlagRequired("filename")
return cmd
}
// Validate validates diff command.
func (o *diffOptions) Validate(cmd *cobra.Command, args []string) error {
if len(args) > 0 {
return errors.New("The diff command takes no arguments.")
if len(args) > 1 {
return errors.New("specify one path to " + constants.KustomizationFileName)
}
return nil
}
// Complete completes diff command.
func (o *diffOptions) Complete(cmd *cobra.Command, args []string) error {
if len(args) == 0 {
o.kustomizationPath = "./"
return nil
}
o.kustomizationPath = args[0]
return nil
}