From 712eb6d27655f1e09059ca0dfb99f9ed3ab43fd1 Mon Sep 17 00:00:00 2001 From: Sam Wronski Date: Thu, 5 Nov 2020 12:23:45 -0800 Subject: [PATCH] Refactor changeset spanning function naming --- cmd/prchecker/main.go | 6 +++--- cmd/prchecker/main_test.go | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cmd/prchecker/main.go b/cmd/prchecker/main.go index 982fe60d7..4459e0d61 100644 --- a/cmd/prchecker/main.go +++ b/cmd/prchecker/main.go @@ -235,7 +235,7 @@ func PullRequestSpanningPathList(repository GitHubService, pullrequest int, path spanningChangesExist := false for _, changeset := range changesets { - if ChangesetSpanningPathList(changeset, paths) { + if changeset.isSpanningPaths(paths) { // When detecting the first spanning changeset print a prefix message if !spanningChangesExist { fmt.Printf("Spanning changesets detected in the following commits:\n\n") @@ -250,9 +250,9 @@ func PullRequestSpanningPathList(repository GitHubService, pullrequest int, path return spanningChangesExist, changesets, nil } -// ChangesetSpanningPathList tests if a changeset is spanning +// isSpanningPaths tests if a changeset is spanning // multiple directory paths. -func ChangesetSpanningPathList(changeset *Changeset, paths []string) bool { +func (changeset *Changeset) isSpanningPaths(paths []string) bool { matchedPath := "" for _, file := range changeset.files { diff --git a/cmd/prchecker/main_test.go b/cmd/prchecker/main_test.go index edb6f9dbe..88bea9c31 100644 --- a/cmd/prchecker/main_test.go +++ b/cmd/prchecker/main_test.go @@ -260,7 +260,7 @@ func TestIsChangesetSpanning(t *testing.T) { changeset := &Changeset{files: tt.changeset} - result := ChangesetSpanningPathList(changeset, tt.files) + result := changeset.isSpanningPaths(tt.files) if result != tt.expected { t.Errorf("got %t, want %t", result, tt.expected)