Merge pull request #77 from uthark/golint

Fix go lint error and add golint checks to a pre-commit hook
This commit is contained in:
Jeff Regan
2018-06-10 10:35:56 -07:00
committed by GitHub
18 changed files with 58 additions and 24 deletions

View File

@@ -68,11 +68,12 @@ func (m ResMap) EncodeAsYaml() ([]byte, error) {
return buf.Bytes(), nil
}
func (m1 ResMap) ErrorIfNotEqual(m2 ResMap) error {
if len(m1) != len(m2) {
// ErrorIfNotEqual returns error if maps are not equal.
func (m ResMap) ErrorIfNotEqual(m2 ResMap) error {
if len(m) != len(m2) {
keySet1 := []resource.ResId{}
keySet2 := []resource.ResId{}
for id := range m1 {
for id := range m {
keySet1 = append(keySet1, id)
}
for id := range m2 {
@@ -80,7 +81,7 @@ func (m1 ResMap) ErrorIfNotEqual(m2 ResMap) error {
}
return fmt.Errorf("maps has different number of entries: %#v doesn't equals %#v", keySet1, keySet2)
}
for id, obj1 := range m1 {
for id, obj1 := range m {
obj2, found := m2[id]
if !found {
return fmt.Errorf("%#v doesn't exist in %#v", id, m2)