diff --git a/plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator_test.go b/plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator_test.go index ea62c1917..3ba3ad8a0 100644 --- a/plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator_test.go +++ b/plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator_test.go @@ -771,8 +771,8 @@ releaseName: podinfo2 assert.Contains(t, string(podinfo2ChartContents), "version: 6.1.8") } -// Addressed: https://github.com/kubernetes-sigs/kustomize/issues/5163 -func TestHelmChartInflationGeneratorWithLocalChartWithVersion5163(t *testing.T) { +// Reference: https://github.com/kubernetes-sigs/kustomize/issues/5163 +func TestHelmChartInflationGeneratorUsingVersionWithoutRepo(t *testing.T) { th := kusttest_test.MakeEnhancedHarnessWithTmpRoot(t). PrepBuiltin("HelmChartInflationGenerator") defer th.Reset() @@ -786,10 +786,10 @@ func TestHelmChartInflationGeneratorWithLocalChartWithVersion5163(t *testing.T) apiVersion: builtin kind: HelmChartInflationGenerator metadata: - name: issue5163 -name: issue5163 + name: foo-chart +name: foo-chart version: 1.0.0 -releaseName: issue5163 +releaseName: foo-chart chartHome: ./charts `) @@ -797,10 +797,11 @@ chartHome: ./charts assert.NoError(t, err) assert.Equal(t, "bar", cm) - chartDir := filepath.Join(th.GetRoot(), "charts/issue5163") + chartDir := filepath.Join(th.GetRoot(), "charts/foo-chart") assert.True(t, th.GetFSys().Exists(chartDir)) chartYamlContent, err := th.GetFSys().ReadFile(filepath.Join(chartDir, "Chart.yaml")) assert.NoError(t, err) + assert.Contains(t, string(chartYamlContent), "name: foo-chart") assert.Contains(t, string(chartYamlContent), "version: 1.0.0") } diff --git a/plugin/builtin/helmchartinflationgenerator/testdata/charts/issue5163/Chart.yaml b/plugin/builtin/helmchartinflationgenerator/testdata/charts/foo-chart/Chart.yaml similarity index 98% rename from plugin/builtin/helmchartinflationgenerator/testdata/charts/issue5163/Chart.yaml rename to plugin/builtin/helmchartinflationgenerator/testdata/charts/foo-chart/Chart.yaml index 2fd90b40b..559af039b 100644 --- a/plugin/builtin/helmchartinflationgenerator/testdata/charts/issue5163/Chart.yaml +++ b/plugin/builtin/helmchartinflationgenerator/testdata/charts/foo-chart/Chart.yaml @@ -1,5 +1,5 @@ apiVersion: v2 -name: issue5163 +name: foo-chart description: A Helm chart for Kubernetes # A chart can be either an 'application' or a 'library' chart. diff --git a/plugin/builtin/helmchartinflationgenerator/testdata/charts/issue5163/templates/configmap.yaml b/plugin/builtin/helmchartinflationgenerator/testdata/charts/foo-chart/templates/configmap.yaml similarity index 100% rename from plugin/builtin/helmchartinflationgenerator/testdata/charts/issue5163/templates/configmap.yaml rename to plugin/builtin/helmchartinflationgenerator/testdata/charts/foo-chart/templates/configmap.yaml diff --git a/plugin/builtin/helmchartinflationgenerator/testdata/charts/issue5163/values.yaml b/plugin/builtin/helmchartinflationgenerator/testdata/charts/foo-chart/values.yaml similarity index 100% rename from plugin/builtin/helmchartinflationgenerator/testdata/charts/issue5163/values.yaml rename to plugin/builtin/helmchartinflationgenerator/testdata/charts/foo-chart/values.yaml