kubernetes-sigs/kustomize
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/kustomize.git synced 2026-06-11 17:12:51 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Skip flaky tests

Browse Source 
Skip tests that behave reliably locally, but are flaky on macOS server.
This commit is contained in:
Anna Song
2022-05-06 08:01:19 -07:00
parent 5948f6aa63
commit 7e0158e1e9
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
api/krusty/remoteload_test.go
View File

@@ -226,14 +226,16 @@ func TestRemoteResourceParameters(t *testing.T) {
httpsMasterBranch := "https://github.com/kubernetes-sigs/kustomize//examples/multibases/dev?ref=master" httpsMasterBranch := "https://github.com/kubernetes-sigs/kustomize//examples/multibases/dev?ref=master"
sshNoParams := "git@github.com:kubernetes-sigs/kustomize//examples/multibases/dev" sshNoParams := "git@github.com:kubernetes-sigs/kustomize//examples/multibases/dev"
// some query parameter combinations not currently supported; should implement in future // cases with expected errors are query parameter combinations that aren't supported yet; should implement in future
tests := map[string]remoteResourceCase{ tests := map[string]remoteResourceCase{
"https no params": { "https no params": {
skip: true, // flaky: passes locally, but sometimes fails on server; fix in future
kustomization: fmt.Sprintf(resourcesField, httpsNoParam), kustomization: fmt.Sprintf(resourcesField, httpsNoParam),
error: true, error: true,
expected: fmt.Sprintf(resourceErrorFormat+repoFindError, httpsNoParam), expected: fmt.Sprintf(resourceErrorFormat+repoFindError, httpsNoParam),
}, },
"https master": { "https master": {
skip: true, // flaky: passes locally, but sometimes fails on server; fix in future
kustomization: fmt.Sprintf(resourcesField, httpsMasterBranch), kustomization: fmt.Sprintf(resourcesField, httpsMasterBranch),
error: true, error: true,
expected: fmt.Sprintf(resourceErrorFormat+repoFindError, httpsMasterBranch), expected: fmt.Sprintf(resourceErrorFormat+repoFindError, httpsMasterBranch),