From 8a8f35863ca849c99f3fbafb1f8be17b7ad0d06c Mon Sep 17 00:00:00 2001 From: Jingfang Liu Date: Mon, 1 Oct 2018 10:53:39 -0700 Subject: [PATCH] change sets.NewString() to []string --- pkg/commands/build_test.go | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/pkg/commands/build_test.go b/pkg/commands/build_test.go index e413ffdea..4d133cd43 100644 --- a/pkg/commands/build_test.go +++ b/pkg/commands/build_test.go @@ -27,7 +27,6 @@ import ( "github.com/ghodss/yaml" - "k8s.io/apimachinery/pkg/util/sets" "sigs.k8s.io/kustomize/pkg/constants" "sigs.k8s.io/kustomize/pkg/fs" ) @@ -81,7 +80,7 @@ func TestBuild(t *testing.T) { updateKustomizeExpected := os.Getenv(updateEnvVar) == "true" fSys := fs.MakeRealFS() - testcases := sets.NewString() + testcases := []string{} filepath.Walk("testdata", func(path string, info os.FileInfo, err error) error { if err != nil { return err @@ -92,18 +91,18 @@ func TestBuild(t *testing.T) { name := filepath.Base(path) if info.IsDir() { if strings.HasPrefix(name, "testcase-") { - testcases.Insert(strings.TrimPrefix(name, "testcase-")) + testcases = append(testcases, strings.TrimPrefix(name, "testcase-")) } return filepath.SkipDir } return nil }) // sanity check that we found the right folder - if !testcases.Has("simple") { + if !stringInSlice("simple", testcases) { t.Fatalf("Error locating testcases") } - for _, testcaseName := range testcases.List() { + for _, testcaseName := range testcases { t.Run(testcaseName, func(t *testing.T) { runBuildTestCase(t, testcaseName, updateKustomizeExpected, fSys) }) }