kubernetes-sigs/kustomize
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/kustomize.git synced 2026-06-11 09:02:53 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

code review

Browse Source
This commit is contained in:
Donny Xia
2020-08-05 11:56:19 -07:00
parent 2f7241f4c3
commit 8cdc97a0dd
2 changed files with 7 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
kyaml/fn/runtime/container/container_test.go
View File

@@ -106,7 +106,7 @@ metadata:
for _, e := range os.Environ() {
// the process env
parts := strings.Split(e, "=")
if parts[0] == "" || parts[1] == "" || shouldEnvIgnored(parts[0]) {
if parts[0] == "" || parts[1] == "" || parts[0] == "TMPDIR" {
continue
}
tt.expectedArgs = append(tt.expectedArgs, "-e", parts[0])
@@ -212,17 +212,13 @@ func TestFilter_ExitCode(t *testing.T) {
}
func TestIgnoreEnv(t *testing.T) {
for _, key := range ignoreEnvKey {
os.Setenv(key, "")
}
os.Setenv("TMPDIR", "")
fltr := Filter{Image: "example.com:version"}
_, args := fltr.getCommand()
for _, arg := range args {
for _, key := range ignoreEnvKey {
if arg == key {
t.Fatalf("%s should not be exported to container", key)
}
if arg == "TMPDIR" {
t.Fatalf("TMPDIR should not be exported to container")
}
}
}