From 91dc6d2a0fa906e82f7d6d41a86c60ec4f3b7772 Mon Sep 17 00:00:00 2001 From: Rob Ferguson Date: Fri, 9 Jul 2021 12:45:47 -0500 Subject: [PATCH] add additional replacement transformer test with todos for failures --- api/krusty/replacementtransformer_test.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/api/krusty/replacementtransformer_test.go b/api/krusty/replacementtransformer_test.go index c125a518d..15c088818 100644 --- a/api/krusty/replacementtransformer_test.go +++ b/api/krusty/replacementtransformer_test.go @@ -344,7 +344,7 @@ spec: } // TODO: Address namePrefix in overlay not applying to replacement targets -// The name in the target deployment should end up being `prefix-source` instead of `source` +// The property `data.blue-name` should end up being `overlay-blue` instead of `blue` // https://github.com/kubernetes-sigs/kustomize/issues/4034 func TestReplacementTransformerWithNamePrefixOverlay(t *testing.T) { th := kusttest_test.MakeEnhancedHarness(t) @@ -391,6 +391,9 @@ metadata: `) } +// TODO: Address namespace in overlay not applying to replacement targets +// The property `data.blue-namespace` should end up being `overlay-namespace` instead of `base-namespace` +// https://github.com/kubernetes-sigs/kustomize/issues/4034 func TestReplacementTransformerWithNamespaceOverlay(t *testing.T) { th := kusttest_test.MakeEnhancedHarness(t) defer th.Reset() @@ -439,6 +442,9 @@ metadata: `) } +// TODO: Address configMapGenerator suffix not applying to replacement targets +// The property `data.blue-name` should end up being `blue-6ct58987ht` instead of `blue` +// https://github.com/kubernetes-sigs/kustomize/issues/4034 func TestReplacementTransformerWithConfigMapGenerator(t *testing.T) { th := kusttest_test.MakeEnhancedHarness(t) defer th.Reset()