From 97c8cd7d1ae6372f0c8fd6a0167317df93e2c84a Mon Sep 17 00:00:00 2001 From: Ed Overton Date: Tue, 2 May 2023 13:15:01 -0400 Subject: [PATCH] perf: eliminate unnecessary RNode creation --- kyaml/yaml/rnode.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/kyaml/yaml/rnode.go b/kyaml/yaml/rnode.go index 266b4153f..7406c525e 100644 --- a/kyaml/yaml/rnode.go +++ b/kyaml/yaml/rnode.go @@ -450,15 +450,13 @@ func (rn *RNode) getMetaData() *yaml.Node { if IsMissingOrNull(rn) { return nil } - var n *RNode + content := rn.Content() if rn.YNode().Kind == DocumentNode { // get the content if this is the document node - n = NewRNode(rn.Content()[0]) - } else { - n = rn + content = content[0].Content } var mf *yaml.Node - visitMappingNodeFields(n.Content(), func(key, value *yaml.Node) { + visitMappingNodeFields(content, func(key, value *yaml.Node) { if !IsYNodeNilOrEmpty(value) { mf = value }