fix exec plugin args handling

api/internal/plugins/execplugin/execplugin.go

@@ -12,6 +12,8 @@ import (
 	"strconv"
 	"strings"
 
+	"github.com/google/shlex"
+
 	"github.com/pkg/errors"
 	"sigs.k8s.io/kustomize/api/resid"
 	"sigs.k8s.io/kustomize/api/resmap"
@@ -86,7 +88,7 @@ func (p *ExecPlugin) processOptionalArgsFields() error {
 	var c argsConfig
 	yaml.Unmarshal(p.cfg, &c)
 	if c.ArgsOneLiner != "" {
-		p.args = strings.Split(c.ArgsOneLiner, " ")
+		p.args, _ = shlex.Split(c.ArgsOneLiner)
 	}
 	if c.ArgsFromFile != "" {
 		content, err := p.h.Loader().Load(c.ArgsFromFile)

api/internal/plugins/execplugin/execplugin_test.go

@@ -43,9 +43,16 @@ s/$BAR/bar/g
 			"metadata": map[string]interface{}{
 				"name": "some-random-name",
 			},
-			"argsOneLiner": "one two",
+			"argsOneLiner": "one two 'foo bar'",
 			"argsFromFile": "sed-input.txt",
 		})
+
+	ldr.AddFile("/app/sed-input.txt", []byte(`
+s/$FOO/foo/g
+s/$BAR/bar baz/g
+ \ \ \ 
+`))
+
 	p := NewExecPlugin(
 		pLdr.AbsolutePluginPath(
 			konfig.DisabledPluginConfig(),
@@ -69,7 +76,7 @@ s/$BAR/bar/g
 
 	expected = `apiVersion: someteam.example.com/v1
 argsFromFile: sed-input.txt
-argsOneLiner: one two
+argsOneLiner: one two 'foo bar'
 kind: SedTransformer
 metadata:
   name: some-random-name
@@ -78,15 +85,16 @@ metadata:
 		t.Fatalf("expected cfg '%s', got '%s'", expected, string(p.Cfg()))
 
 	}
-	if len(p.Args()) != 5 {
-		t.Fatalf("unexpected arg len %d, %v", len(p.Args()), p.Args())
+	if len(p.Args()) != 6 {
+		t.Fatalf("unexpected arg len %d, %#v", len(p.Args()), p.Args())
 	}
 	if p.Args()[0] != "one" ||
 		p.Args()[1] != "two" ||
-		p.Args()[2] != "s/$FOO/foo/g" ||
-		p.Args()[3] != "s/$BAR/bar/g" ||
-		p.Args()[4] != "\\ \\ \\ " {
-		t.Fatalf("unexpected arg array: %v", p.Args())
+		p.Args()[2] != "foo bar" ||
+		p.Args()[3] != "s/$FOO/foo/g" ||
+		p.Args()[4] != "s/$BAR/bar baz/g" ||
+		p.Args()[5] != "\\ \\ \\ " {
+		t.Fatalf("unexpected arg array: %#v", p.Args())
 	}
 }