kubernetes-sigs/kustomize
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/kustomize.git synced 2026-06-12 01:14:22 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

fix kyaml issue where dropping Style created issues

Browse Source 
dropping the node style creates a compatibility issue where quotes around "on" are dropped
because yaml.v3 interprets it as a string.

other yaml parsers interpret on as a bool value, and parse it as a bool rather than string.

fix: retain the original style so it is kept as quoted.

- fmt: don't drop the styles
- merge2: keep the style when merging elements
- setting a field: if changing the value of a scalar field, retain its style by default
This commit is contained in:
Phillip Wittrock
2019-12-19 15:05:49 -08:00
parent 7e56c2c768
commit 98431f6a00
13 changed files with 147 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
kyaml/yaml/merge2/element_test.go
View File

@@ -23,8 +23,7 @@ kind: Deployment
items:
- name: foo
image: foo:v1
command:
- run.sh
command: ['run.sh']
`,
},
@@ -47,8 +46,7 @@ kind: Deployment
items:
- name: foo
image: foo:v1
command:
- run.sh
command: ['run.sh']
`,
},
@@ -62,15 +60,14 @@ items:
`,
`
kind: Deployment
items: {}
items: []
`,
`
kind: Deployment
items:
- name: foo
image: foo:v1
command:
- run.sh
command: ['run.sh']
`,
},
@@ -90,8 +87,7 @@ kind: Deployment
items:
- name: foo
image: foo:v1
command:
- run.sh
command: ['run.sh']
`,
},
@@ -118,8 +114,7 @@ items:
image: foo:v1
- name: bar
image: bar:v1
command:
- run2.sh
command: ['run2.sh']
`,
},
@@ -146,8 +141,7 @@ items:
image: foo:v1
- name: bar
image: bar:v1
command:
- run2.sh
command: ['run2.sh']
`,
},
@@ -174,8 +168,7 @@ items:
image: foo:v1
- name: bar
image: bar:v1
command:
- run2.sh
command: ['run2.sh']
`,
},
@@ -205,8 +198,7 @@ items:
image: foo:v1
- name: bar
image: bar:v1
command:
- run2.sh
command: ['run2.sh']
`,
},
@@ -225,8 +217,7 @@ items:
image: foo:v1
- name: bar
image: bar:v1
command:
- run2.sh
command: ['run2.sh']
`,
`
kind: Deployment
@@ -235,8 +226,7 @@ items:
image: foo:v1
- name: bar
image: bar:v1
command:
- run2.sh
command: ['run2.sh']
`,
},
@@ -255,8 +245,7 @@ items:
image: foo:v1
- name: bar
image: bar:v1
command:
- run2.sh
command: ['run2.sh']
`,
`
kind: Deployment