kubernetes-sigs/kustomize
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/kustomize.git synced 2026-06-12 01:14:22 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

code review

Browse Source
This commit is contained in:
Donny Xia
2020-10-20 12:39:50 -07:00
parent 92826c6a1e
commit 9c7b4fddf9
2 changed files with 52 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
kyaml/yaml/fns_test.go
View File

@@ -65,26 +65,17 @@ func TestGetElementByIndex(t *testing.T) {
`)
assert.NoError(t, err)
rn, err := node.Pipe(GetElementByIndex("0"))
rn, err := node.Pipe(GetElementByIndex(0))
assert.NoError(t, err)
assert.Equal(t, "0\n", assertNoErrorString(t)(rn.String()))
rn, err = node.Pipe(GetElementByIndex("2"))
rn, err = node.Pipe(GetElementByIndex(2))
assert.NoError(t, err)
assert.Equal(t, "2\n", assertNoErrorString(t)(rn.String()))
rn, err = node.Pipe(GetElementByIndex("-"))
rn, err = node.Pipe(GetElementByIndex(-1))
assert.NoError(t, err)
assert.Equal(t, "2\n", assertNoErrorString(t)(rn.String()))
_, err = node.Pipe(GetElementByIndex("#"))
assert.Errorf(t, err, "unknown index #")
rn, _ = node.Pipe(GetElementByIndex("-1"))
assert.Nil(t, rn)
rn, _ = node.Pipe(GetElementByIndex("4"))
assert.Nil(t, rn)
}
func TestGetElementByKey(t *testing.T) {
@@ -428,7 +419,7 @@ j: k
assert.Nil(t, rn)
rn, err = node.Pipe(Lookup("a", "b", "-1"))
assert.NoError(t, err)
assert.Errorf(t, err, "array index -1 cannot be negative")
assert.Equal(t, s, assertNoErrorString(t)(node.String()))
assert.Nil(t, rn)