From 08963ba5038b7d788ff8357d1b48ad542d0e9c2a Mon Sep 17 00:00:00 2001
From: Guangming Wang <guangming.wang@daocloud.io>
Date: Wed, 25 Sep 2019 23:04:39 +0800
Subject: [PATCH] improve test code coverage in transformers

Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>
---
 pkg/transformers/refvars_test.go | 61 ++++++++++++++++++++++++--------
 1 file changed, 46 insertions(+), 15 deletions(-)

diff --git a/pkg/transformers/refvars_test.go b/pkg/transformers/refvars_test.go
index 120f9ec4b..0dc5e58a0 100644
--- a/pkg/transformers/refvars_test.go
+++ b/pkg/transformers/refvars_test.go
@@ -38,7 +38,11 @@ func TestVarRef(t *testing.T) {
 					"BOO": true,
 				},
 				fs: []config.FieldSpec{
-					{Gvk: gvk.Gvk{Version: "v1", Kind: "ConfigMap"}, Path: "data"},
+					{Gvk: gvk.Gvk{Version: "v1", Kind: "ConfigMap"}, Path: "data/map"},
+					{Gvk: gvk.Gvk{Version: "v1", Kind: "ConfigMap"}, Path: "data/slice"},
+					{Gvk: gvk.Gvk{Version: "v1", Kind: "ConfigMap"}, Path: "data/interface"},
+					{Gvk: gvk.Gvk{Version: "v1", Kind: "ConfigMap"}, Path: "data/nil"},
+					{Gvk: gvk.Gvk{Version: "v1", Kind: "ConfigMap"}, Path: "data/num"},
 				},
 				res: resmaptest_test.NewRmBuilder(t, rf).
 					Add(map[string]interface{}{
@@ -48,14 +52,27 @@ func TestVarRef(t *testing.T) {
 							"name": "cm1",
 						},
 						"data": map[string]interface{}{
-							"item1": "$(FOO)",
-							"item2": "bla",
-							"item3": "$(BAZ)",
-							"item4": "$(BAZ)+$(BAZ)",
-							"item5": "$(BOO)",
-							"item6": "if $(BOO)",
-						},
-					}).ResMap(),
+							"map": map[string]interface{}{
+								"item1": "$(FOO)",
+								"item2": "bla",
+								"item3": "$(BAZ)",
+								"item4": "$(BAZ)+$(BAZ)",
+								"item5": "$(BOO)",
+								"item6": "if $(BOO)",
+								"item7": 2019,
+							},
+							"slice": []interface{}{
+								"$(FOO)",
+								"bla",
+								"$(BAZ)",
+								"$(BAZ)+$(BAZ)",
+								"$(BOO)",
+								"if $(BOO)",
+							},
+							"interface": "$(FOO)",
+							"nil":       nil,
+							"num":       2019,
+						}}).ResMap(),
 			},
 			expected: expected{
 				res: resmaptest_test.NewRmBuilder(t, rf).
@@ -66,12 +83,26 @@ func TestVarRef(t *testing.T) {
 							"name": "cm1",
 						},
 						"data": map[string]interface{}{
-							"item1": "replacementForFoo",
-							"item2": "bla",
-							"item3": int64(5),
-							"item4": "5+5",
-							"item5": true,
-							"item6": "if true",
+							"map": map[string]interface{}{
+								"item1": "replacementForFoo",
+								"item2": "bla",
+								"item3": int64(5),
+								"item4": "5+5",
+								"item5": true,
+								"item6": "if true",
+								"item7": 2019,
+							},
+							"slice": []interface{}{
+								"replacementForFoo",
+								"bla",
+								int64(5),
+								"5+5",
+								true,
+								"if true",
+							},
+							"interface": "replacementForFoo",
+							"nil":       nil,
+							"num":       2019,
 						}}).ResMap(),
 				unused: []string{"BAR"},
 			},