From a167084ccffa8a2b18180bc69e0e1aceaabed10c Mon Sep 17 00:00:00 2001 From: Li Zhijian Date: Mon, 8 Feb 2021 13:41:45 +0800 Subject: [PATCH] api/internal/crawl/index/elasticsearch: Fix ineffectual assignment to err Signed-off-by: Li Zhijian --- api/internal/crawl/index/elasticsearch.go | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/api/internal/crawl/index/elasticsearch.go b/api/internal/crawl/index/elasticsearch.go index a1f465a36..c49a46da5 100644 --- a/api/internal/crawl/index/elasticsearch.go +++ b/api/internal/crawl/index/elasticsearch.go @@ -191,7 +191,8 @@ func (idx *index) Put(uniqueID string, doc interface{}) error { } if exists { - docBytes, err := json.Marshal(doc) + var docBytes []byte + docBytes, err = json.Marshal(doc) if err != nil { return err } @@ -204,12 +205,14 @@ func (idx *index) Put(uniqueID string, doc interface{}) error { Body: bytes.NewReader(body), DocumentID: uniqueID, } - res, err := req.Do(idx.ctx, idx.client) + var res *esapi.Response + res, err = req.Do(idx.ctx, idx.client) err = idx.responseErrorOrNil("could not update document", res, err, ignoreResponseBody) } else { - body, err := json.Marshal(doc) + var body []byte + body, err = json.Marshal(doc) if err != nil { return err } @@ -219,7 +222,8 @@ func (idx *index) Put(uniqueID string, doc interface{}) error { Body: bytes.NewReader(body), DocumentID: uniqueID, } - res, err := req.Do(idx.ctx, idx.client) + var res *esapi.Response + res, err = req.Do(idx.ctx, idx.client) err = idx.responseErrorOrNil("could not insert document", res, err, ignoreResponseBody)