From af29855802482528458b2af82f9abb0f921d27ad Mon Sep 17 00:00:00 2001 From: Ace Eldeib Date: Fri, 19 Jul 2019 12:51:17 -0700 Subject: [PATCH 1/2] fix: windows builds --- pkg/plugins/execplugin.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/plugins/execplugin.go b/pkg/plugins/execplugin.go index 21421ff06..be44c8e73 100644 --- a/pkg/plugins/execplugin.go +++ b/pkg/plugins/execplugin.go @@ -23,7 +23,6 @@ import ( "os" "os/exec" "strings" - "syscall" "sigs.k8s.io/kustomize/v3/pkg/ifc" "sigs.k8s.io/kustomize/v3/pkg/resid" @@ -108,7 +107,7 @@ func (p *ExecPlugin) writeConfig() (string, error) { if err != nil { return "", err } - syscall.Mkfifo(tmpFile.Name(), 0600) + stdout, err := os.OpenFile(tmpFile.Name(), os.O_RDWR, 0600) if err != nil { return "", err From c2cc93a00997c3d331183f5f2344afbbbbc589a7 Mon Sep 17 00:00:00 2001 From: Ace Eldeib Date: Fri, 19 Jul 2019 17:38:24 -0700 Subject: [PATCH 2/2] fix: tempfile(?) --- pkg/plugins/execplugin.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkg/plugins/execplugin.go b/pkg/plugins/execplugin.go index be44c8e73..38699a745 100644 --- a/pkg/plugins/execplugin.go +++ b/pkg/plugins/execplugin.go @@ -160,6 +160,9 @@ func (p *ExecPlugin) invokePlugin(input []byte) ([]byte, error) { if err != nil { return nil, err } + // Cleanup plugin config file after execution + defer os.Remove(args[0]) + cmd := exec.Command(p.path, args...) cmd.Env = p.getEnv() cmd.Stdin = bytes.NewReader(input)