fix issue with multiline configmap data with extra space

This commit is contained in:
natasha41575
2021-12-03 15:16:35 -08:00
parent c4a8a99834
commit a3d547ccd3
3 changed files with 17 additions and 7 deletions

View File

@@ -5,6 +5,7 @@ package generators
import ( import (
"fmt" "fmt"
"strings"
"github.com/go-errors/errors" "github.com/go-errors/errors"
"sigs.k8s.io/kustomize/api/ifc" "sigs.k8s.io/kustomize/api/ifc"
@@ -50,7 +51,11 @@ func makeValidatedDataMap(
return nil, errors.Errorf( return nil, errors.Errorf(
"configmap %s illegally repeats the key `%s`", name, p.Key) "configmap %s illegally repeats the key `%s`", name, p.Key)
} }
knownKeys[p.Key] = p.Value lines := strings.Split(p.Value, "\n")
for i := range lines {
lines[i] = strings.TrimSuffix(lines[i], " ")
}
knownKeys[p.Key] = strings.Join(lines, "\n")
} }
return knownKeys, nil return knownKeys, nil
} }

View File

@@ -292,8 +292,10 @@ metadata:
--- ---
apiVersion: v1 apiVersion: v1
data: data:
nonsense: "Lorem ipsum dolor sit amet, consectetur\nadipiscing elit, sed do eiusmod nonsense: |
tempor\nincididunt ut labore et dolore magna aliqua. \n" Lorem ipsum dolor sit amet, consectetur
adipiscing elit, sed do eiusmod tempor
incididunt ut labore et dolore magna aliqua.
kind: ConfigMap kind: ConfigMap
metadata: metadata:
annotations: annotations:
@@ -302,6 +304,6 @@ metadata:
app: mungebot app: mungebot
org: kubernetes org: kubernetes
repo: test-infra repo: test-infra
name: test-infra-app-config-49d6f5h7b5 name: test-infra-app-config-4thktg822m
`) `)
} }

View File

@@ -593,15 +593,18 @@ bla
th.AssertActualEqualsExpected( th.AssertActualEqualsExpected(
m, `apiVersion: v1 m, `apiVersion: v1
data: data:
cfg.text: "bla\nbla\nbla \n" cfg.text: |
bla
bla
bla
kind: ConfigMap kind: ConfigMap
metadata: metadata:
name: config_bla-d6m295b8c5 name: config_bla-4k548khbf5
`) `)
} }
// regression test to record the behavior prior to the fix for https://github.com/kubernetes-sigs/kustomize/issues/4287 // regression test to record the behavior prior to the fix for https://github.com/kubernetes-sigs/kustomize/issues/4287
// so that the fix does not affect leading and trailing newlines in ConfigMap data // to ensure that the fix does not affect leading and trailing newlines in ConfigMap data
func TestMultilineDataEndsLeadingAndTrailingNewlines(t *testing.T) { func TestMultilineDataEndsLeadingAndTrailingNewlines(t *testing.T) {
th := kusttest_test.MakeHarness(t) th := kusttest_test.MakeHarness(t)
th.WriteK(".", ` th.WriteK(".", `