From a4c69d9cde1c105e02559b778025d01c88c1a25e Mon Sep 17 00:00:00 2001 From: Frank Farzan Date: Mon, 9 Dec 2019 14:37:57 -0800 Subject: [PATCH] Fix 'config run' by removing default mount. In, pull #1822 mount logic was refactored where the default mount using zero-value no longer makes sense and leads to this failure: "invalid argument "type=,src=,dst=:ro" for "--mount" flag: type is required" I think the intent here was to remove default mount. --- kyaml/runfn/runfn.go | 2 -- kyaml/runfn/runfn_test.go | 5 +---- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/kyaml/runfn/runfn.go b/kyaml/runfn/runfn.go index 366aaa519..d4918e212 100644 --- a/kyaml/runfn/runfn.go +++ b/kyaml/runfn/runfn.go @@ -92,8 +92,6 @@ func (r *RunFns) init() { // if containerFilterProvider hasn't been set, use the default if r.containerFilterProvider == nil { r.containerFilterProvider = func(image, path string, api *yaml.RNode) kio.Filter { - defaultMount := filters.StorageMount{} - r.StorageMounts = append(r.StorageMounts, defaultMount) cf := &filters.ContainerFilter{Image: image, Config: api, StorageMounts: r.StorageMounts} return cf } diff --git a/kyaml/runfn/runfn_test.go b/kyaml/runfn/runfn_test.go index 5428a5141..3ff988ffd 100644 --- a/kyaml/runfn/runfn_test.go +++ b/kyaml/runfn/runfn_test.go @@ -40,10 +40,7 @@ kind: return } filter := instance.containerFilterProvider("example.com:version", "", api) - defaultMount := filters.StorageMount{} - mounts := []filters.StorageMount{} - mounts = append(mounts, defaultMount) - assert.Equal(t, &filters.ContainerFilter{Image: "example.com:version", Config: api, StorageMounts: mounts}, filter) + assert.Equal(t, &filters.ContainerFilter{Image: "example.com:version", Config: api}, filter) } func TestCmd_Execute(t *testing.T) {