Improve unstruct test coverage and error messages.

internal/k8sdeps/kunstruct/kunstruct_test.go

@@ -35,43 +35,114 @@ func TestGetFieldValue(t *testing.T) {
 				"port": "80",
 			},
 		},
+		"this": map[string]interface{}{
+			"is": map[string]interface{}{
+				"aNumber":    1000,
+				"aNilValue":  nil,
+				"anEmptyMap": map[string]interface{}{},
+				"unrecognizable": testing.InternalExample{
+					Name: "fooBar",
+				},
+			},
+		},
 	})
 
 	tests := []struct {
+		name          string
 		pathToField   string
 		expectedValue string
 		errorExpected bool
+		errorMsg      string
 	}{
 		{
+			name:          "oneField",
 			pathToField:   "Kind",
 			expectedValue: "Service",
 			errorExpected: false,
 		},
 		{
+			name:          "twoFields",
 			pathToField:   "metadata.name",
 			expectedValue: "service-name",
 			errorExpected: false,
 		},
 		{
-			pathToField:   "metadata.non-existing-field",
-			expectedValue: "",
-			errorExpected: true,
-		},
-		{
+			name:          "threeFields",
 			pathToField:   "spec.ports.port",
 			expectedValue: "80",
 			errorExpected: false,
 		},
+		{
+			name:          "empty",
+			pathToField:   "",
+			errorExpected: true,
+			errorMsg:      "at path '': no field named ''",
+		},
+		{
+			name:          "emptyDotEmpty",
+			pathToField:   ".",
+			errorExpected: true,
+			errorMsg:      "at path '.': no field named ''",
+		},
+		{
+			name:          "twoFieldsOneMissing",
+			pathToField:   "metadata.banana",
+			errorExpected: true,
+			errorMsg:      "at path 'metadata.banana': no field named 'banana'",
+		},
+		{
+			name:          "deeperMissingField",
+			pathToField:   "this.is.aDeep.field.that.does.not.exist",
+			errorExpected: true,
+			errorMsg:      "at path 'this.is.aDeep.field.that.does.not.exist': no field named 'aDeep'",
+		},
+		{
+			name:          "emptyMap",
+			pathToField:   "this.is.anEmptyMap",
+			errorExpected: true,
+			errorMsg:      "at path 'this.is.anEmptyMap': value at 'anEmptyMap' not a string",
+		},
+		{
+			name:          "numberAsValue",
+			pathToField:   "this.is.aNumber",
+			errorExpected: true,
+			errorMsg:      "at path 'this.is.aNumber': value at 'aNumber' not a string",
+		},
+		{
+			name:          "nilAsValue",
+			pathToField:   "this.is.aNilValue",
+			errorExpected: true,
+			errorMsg:      "at path 'this.is.aNilValue': value at 'aNilValue' not a string",
+		},
+		{
+			name:          "unrecognizable",
+			pathToField:   "this.is.unrecognizable.Name",
+			errorExpected: true,
+			errorMsg:      "at path 'this.is.unrecognizable.Name': Expected map at unrecognizable, but got testing.InternalExample={fooBar <nil>  false}",
+		},
 	}
 
 	for _, test := range tests {
 		s, err := kunstructured.GetFieldValue(test.pathToField)
-		if test.errorExpected && err == nil {
-			t.Fatalf("should return error, but no error returned")
-		} else {
-			if test.expectedValue != s {
-				t.Fatalf("Got:%s expected:%s", s, test.expectedValue)
+		if test.errorExpected {
+			if err == nil {
+				t.Fatalf("%q; path %q - should return error, but no error returned",
+					test.name, test.pathToField)
 			}
+			if test.errorMsg != err.Error() {
+				t.Fatalf("%q; path %q - expected error: \"%s\", got error: \"%v\"",
+					test.name, test.pathToField, test.errorMsg, err.Error())
+			}
+			continue
 		}
+		if err != nil {
+			t.Fatalf("%q; path %q - unexpected error %v",
+				test.name, test.pathToField, err)
+		}
+		if test.expectedValue != s {
+			t.Fatalf("%q; Got: %s expected: %s",
+				test.name, s, test.expectedValue)
+		}
+
 	}
 }