Make plugin utils package.

api/internal/plugins/compiler/compiler.go

@@ -13,6 +13,7 @@ import (
 	"strings"
 
 	"github.com/pkg/errors"
+	"sigs.k8s.io/kustomize/api/internal/plugins/utils"
 )
 
 // Compiler creates Go plugin object files.
@@ -64,7 +65,7 @@ func (b *Compiler) Cleanup() {
 // ${pluginRoot}/${g}/${v}/$lower(${k} and places
 // object code next to source code.
 func (b *Compiler) Compile() error {
-	if !FileExists(b.srcPath()) {
+	if !utils.FileExists(b.srcPath()) {
 		return fmt.Errorf("cannot find source at '%s'", b.srcPath())
 	}
 	// If you use an IDE, make sure it's go build and test flags
@@ -77,8 +78,8 @@ func (b *Compiler) Compile() error {
 		"plugin",
 		"-o", b.objFile(),
 	}
-	goBin := goBin()
-	if !FileExists(goBin) {
+	goBin := utils.GoBin()
+	if !utils.FileExists(goBin) {
 		return fmt.Errorf(
 			"cannot find go compiler %s", goBin)
 	}
@@ -95,7 +96,7 @@ func (b *Compiler) Compile() error {
 			err, "cannot compile %s:\nSTDERR\n%s\n",
 			b.srcPath(), b.stderr.String())
 	}
-	if result := filepath.Join(b.workDir, b.objFile()); !FileExists(result) {
+	if result := filepath.Join(b.workDir, b.objFile()); !utils.FileExists(result) {
 		return fmt.Errorf("post compile, cannot find '%s'", result)
 	}
 	return nil

api/internal/plugins/compiler/compiler_test.go

@@ -9,11 +9,12 @@ import (
 
 	"sigs.k8s.io/kustomize/api/filesys"
 	. "sigs.k8s.io/kustomize/api/internal/plugins/compiler"
+	"sigs.k8s.io/kustomize/api/internal/plugins/utils"
 )
 
 // Regression coverage over compiler behavior.
 func TestCompiler(t *testing.T) {
-	srcRoot, err := DeterminePluginSrcRoot(filesys.MakeFsOnDisk())
+	srcRoot, err := utils.DeterminePluginSrcRoot(filesys.MakeFsOnDisk())
 	if err != nil {
 		t.Error(err)
 	}
@@ -29,11 +30,11 @@ func TestCompiler(t *testing.T) {
 	if err != nil {
 		t.Error(err)
 	}
-	if !FileExists(expectObj) {
+	if !utils.FileExists(expectObj) {
 		t.Errorf("didn't find expected obj file %s", expectObj)
 	}
 	c.Cleanup()
-	if FileExists(expectObj) {
+	if utils.FileExists(expectObj) {
 		t.Errorf("obj file '%s' should be gone", expectObj)
 	}
 
@@ -48,11 +49,11 @@ func TestCompiler(t *testing.T) {
 	if err != nil {
 		t.Error(err)
 	}
-	if !FileExists(expectObj) {
+	if !utils.FileExists(expectObj) {
 		t.Errorf("didn't find expected obj file %s", expectObj)
 	}
 	c.Cleanup()
-	if FileExists(expectObj) {
+	if utils.FileExists(expectObj) {
 		t.Errorf("obj file '%s' should be gone", expectObj)
 	}
 }

api/internal/plugins/compiler/utils.go

@@ -1,115 +0,0 @@
-// Copyright 2020 The Kubernetes Authors.
-// SPDX-License-Identifier: Apache-2.0
-
-package compiler
-
-import (
-	"os"
-	"path/filepath"
-	"runtime"
-	"time"
-
-	"sigs.k8s.io/kustomize/api/filesys"
-	"sigs.k8s.io/kustomize/api/konfig"
-)
-
-func goBin() string {
-	return filepath.Join(runtime.GOROOT(), "bin", "go")
-}
-
-// DeterminePluginSrcRoot guesses where the user
-// has her ${g}/${v}/$lower(${k})/${k}.go files.
-func DeterminePluginSrcRoot(fSys filesys.FileSystem) (string, error) {
-	return konfig.FirstDirThatExistsElseError(
-		"source directory", fSys, []konfig.NotedFunc{
-			{
-				Note: "relative to unit test",
-				F: func() string {
-					return filepath.Clean(
-						filepath.Join(
-							os.Getenv("PWD"),
-							"..", "..",
-							konfig.RelPluginHome))
-				},
-			},
-			{
-				Note: "relative to unit test (internal pkg)",
-				F: func() string {
-					return filepath.Clean(
-						filepath.Join(
-							os.Getenv("PWD"),
-							"..", "..", "..", "..",
-							konfig.RelPluginHome))
-				},
-			},
-			{
-				Note: "relative to api package",
-				F: func() string {
-					return filepath.Clean(
-						filepath.Join(
-							os.Getenv("PWD"),
-							"..", "..", "..",
-							konfig.RelPluginHome))
-				},
-			},
-			{
-				Note: "old style $GOPATH",
-				F: func() string {
-					return filepath.Join(
-						os.Getenv("GOPATH"),
-						"src", konfig.DomainName,
-						konfig.ProgramName, konfig.RelPluginHome)
-				},
-			},
-			{
-				Note: "HOME with literal 'gopath'",
-				F: func() string {
-					return filepath.Join(
-						konfig.HomeDir(), "gopath",
-						"src", konfig.DomainName,
-						konfig.ProgramName, konfig.RelPluginHome)
-				},
-			},
-			{
-				Note: "home directory",
-				F: func() string {
-					return filepath.Join(
-						konfig.HomeDir(), konfig.DomainName,
-						konfig.ProgramName, konfig.RelPluginHome)
-				},
-			},
-		})
-}
-
-// FileYoungerThan returns true if the file both exists and has an
-// age is <= the Duration argument.
-func FileYoungerThan(path string, d time.Duration) bool {
-	fi, err := os.Stat(path)
-	if err != nil {
-		if os.IsNotExist(err) {
-			return false
-		}
-	}
-	return time.Since(fi.ModTime()) <= d
-}
-
-// FileModifiedAfter returns true if the file both exists and was
-// modified after the given time..
-func FileModifiedAfter(path string, t time.Time) bool {
-	fi, err := os.Stat(path)
-	if err != nil {
-		if os.IsNotExist(err) {
-			return false
-		}
-	}
-	return fi.ModTime().After(t)
-}
-
-func FileExists(path string) bool {
-	if _, err := os.Stat(path); err != nil {
-		if os.IsNotExist(err) {
-			return false
-		}
-	}
-	return true
-}

api/internal/plugins/compiler/utils_test.go

@@ -1,26 +0,0 @@
-// Copyright 2020 The Kubernetes Authors.
-// SPDX-License-Identifier: Apache-2.0
-
-package compiler
-
-import (
-	"path/filepath"
-	"strings"
-	"testing"
-
-	"sigs.k8s.io/kustomize/api/filesys"
-	"sigs.k8s.io/kustomize/api/konfig"
-)
-
-func TestDeterminePluginSrcRoot(t *testing.T) {
-	actual, err := DeterminePluginSrcRoot(filesys.MakeFsOnDisk())
-	if err != nil {
-		t.Error(err)
-	}
-	if !filepath.IsAbs(actual) {
-		t.Errorf("expected absolute path, but got '%s'", actual)
-	}
-	if !strings.HasSuffix(actual, konfig.RelPluginHome) {
-		t.Errorf("expected suffix '%s' in '%s'", konfig.RelPluginHome, actual)
-	}
-}