Remove Functionality that Pulls Env Variables from Empty Keys

api/kv/kv.go

@@ -7,7 +7,6 @@ import (
 	"bufio"
 	"bytes"
 	"fmt"
-	"os"
 	"strings"
 	"unicode"
 	"unicode/utf8"
@@ -162,14 +161,8 @@ func (kvl *loader) keyValuesFromLine(line []byte, currentLine int) (types.Pair,
 	if len(data) == 2 {
 		kv.Value = data[1]
 	} else {
-		// No value (no `=` in the line) is a signal to obtain the value
+		// If there is value (no `=` in the line), we set value to an empty string
-		// from the environment. This behaviour was accidentally imported from kubectl code, and
+		kv.Value = ""
-		// will be removed in the next major release of Kustomize.
-		_, _ = fmt.Fprintln(os.Stderr, "WARNING: "+
-			"This Kustomization is relying on a bug that loads values from the environment "+
-			"when they are omitted from an env file. "+
-			"This behaviour will be removed in the next major release of Kustomize.")
-		kv.Value = os.Getenv(key)
 	}
 	kv.Key = key
 	return kv, nil

api/kv/kv_test.go

@@ -50,6 +50,26 @@ func TestKeyValuesFromLines(t *testing.T) {
 			},
 			expectedErr: false,
 		},
+		{
+			desc: "no value with equals",
+			content: `
+		k1=
+		`,
+			expectedPairs: []types.Pair{
+				{Key: "k1", Value: ""},
+			},
+			expectedErr: false,
+		},
+		{
+			desc: "no value without equals",
+			content: `
+		k1
+		`,
+			expectedPairs: []types.Pair{
+				{Key: "k1", Value: ""},
+			},
+			expectedErr: false,
+		},
 		// TODO: add negative testcases
 	}