kubernetes-sigs/kustomize
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/kustomize.git synced 2026-06-30 09:51:23 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Fix TODO comment syntax

Browse Source
This commit is contained in:
Anna Song
2022-05-06 09:24:23 -07:00
parent 7e0158e1e9
commit b8d2ff2afa
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
api/krusty/remoteload_test.go
View File

@@ -128,7 +128,7 @@ namePrefix: dev-`,
} }
func TestRemoteResourceSsh(t *testing.T) { func TestRemoteResourceSsh(t *testing.T) {
// skip all tests until server has ssh keys // TODO: add ssh keys to server to run these tests
tests := map[string]remoteResourceCase{ tests := map[string]remoteResourceCase{
"scp shorthand": { "scp shorthand": {
skip: true, skip: true,
@@ -168,7 +168,7 @@ func TestRemoteResourcePort(t *testing.T) {
sshURL := "ssh://git@github.com:22/kubernetes-sigs/kustomize//examples/multibases/dev/?ref=v1.0.6" sshURL := "ssh://git@github.com:22/kubernetes-sigs/kustomize//examples/multibases/dev/?ref=v1.0.6"
httpsURL := "https://github.com:443/kubernetes-sigs/kustomize//examples/multibases/dev/?ref=v1.0.6" httpsURL := "https://github.com:443/kubernetes-sigs/kustomize//examples/multibases/dev/?ref=v1.0.6"
// ports not currently supported; should implement in future // TODO: ports not currently supported; implement in future
tests := map[string]remoteResourceCase{ tests := map[string]remoteResourceCase{
"ssh": { "ssh": {
skip: true, skip: true,
@@ -226,16 +226,18 @@ func TestRemoteResourceParameters(t *testing.T) {
httpsMasterBranch := "https://github.com/kubernetes-sigs/kustomize//examples/multibases/dev?ref=master" httpsMasterBranch := "https://github.com/kubernetes-sigs/kustomize//examples/multibases/dev?ref=master"
sshNoParams := "git@github.com:kubernetes-sigs/kustomize//examples/multibases/dev" sshNoParams := "git@github.com:kubernetes-sigs/kustomize//examples/multibases/dev"
// cases with expected errors are query parameter combinations that aren't supported yet; should implement in future // TODO: cases with expected errors are query parameter combinations that aren't supported yet; implement in future
tests := map[string]remoteResourceCase{ tests := map[string]remoteResourceCase{
// TODO: fix flaky test that passes locally, but sometimes fails on server
"https no params": { "https no params": {
skip: true, // flaky: passes locally, but sometimes fails on server; fix in future skip: true,
kustomization: fmt.Sprintf(resourcesField, httpsNoParam), kustomization: fmt.Sprintf(resourcesField, httpsNoParam),
error: true, error: true,
expected: fmt.Sprintf(resourceErrorFormat+repoFindError, httpsNoParam), expected: fmt.Sprintf(resourceErrorFormat+repoFindError, httpsNoParam),
}, },
// TODO: fix flaky test that passes locally, but sometimes fails on server
"https master": { "https master": {
skip: true, // flaky: passes locally, but sometimes fails on server; fix in future skip: true,
kustomization: fmt.Sprintf(resourcesField, httpsMasterBranch), kustomization: fmt.Sprintf(resourcesField, httpsMasterBranch),
error: true, error: true,
expected: fmt.Sprintf(resourceErrorFormat+repoFindError, httpsMasterBranch), expected: fmt.Sprintf(resourceErrorFormat+repoFindError, httpsMasterBranch),