diff --git a/cmd/config/internal/commands/run-fns.go b/cmd/config/internal/commands/run-fns.go index 260808561..38ba38190 100644 --- a/cmd/config/internal/commands/run-fns.go +++ b/cmd/config/internal/commands/run-fns.go @@ -217,8 +217,8 @@ func toStorageMounts(mounts []string) []filters.StorageMount { } func (r *RunFnRunner) preRunE(c *cobra.Command, args []string) error { - if r.EnableStar != (r.StarPath != "") { - return errors.Errorf("must specify --star-path with --enable-star") + if !r.EnableStar && r.StarPath != "" { + return errors.Errorf("must specify --enable-star with --star-path") } if c.ArgsLenAtDash() >= 0 && r.Image == "" && diff --git a/cmd/config/internal/commands/run_test.go b/cmd/config/internal/commands/run_test.go index 4c3c6d4fc..7a3bf6939 100644 --- a/cmd/config/internal/commands/run_test.go +++ b/cmd/config/internal/commands/run_test.go @@ -183,7 +183,7 @@ apiVersion: v1 "--star-name", "foo", "--", "Foo", "g=h"}, path: "dir", - err: "must specify --star-path with --enable-star", + err: "must specify --enable-star with --star-path", }, { name: "image-star-not-enabled", @@ -193,7 +193,17 @@ apiVersion: v1 "--star-name", "foo", "--", "Foo", "g=h"}, path: "dir", - err: "must specify --star-path with --enable-star", + err: "must specify --enable-star with --star-path", + }, + { + name: "star-enabled", + args: []string{"run", "dir", "--enable-star"}, + path: "dir", + expectedStruct: &runfn.RunFns{ + Path: "dir", + NetworkName: "bridge", + EnableStarlark: true, + }, }, { name: "function paths",